From: Wootak Jung <wootak.jung@samsung.com>
Date: Mon, 5 Oct 2020 04:56:05 +0000 (+0900)
Subject: Fix coverity issue
X-Git-Tag: submit/tizen/20201005.072910^0
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=refs%2Fheads%2Ftizen_6.0;p=platform%2Fcore%2Ftelephony%2Flibcall-manager.git

Fix coverity issue

Change-Id: I0f2ca17f1177f6aca1ed3caa30c8e474ccb2f86a
Signed-off-by: Wootak Jung <wootak.jung@samsung.com>
---

diff --git a/src/call-manager.c b/src/call-manager.c
index c6b74bc..71e63de 100644
--- a/src/call-manager.c
+++ b/src/call-manager.c
@@ -519,14 +519,16 @@ EXPORT_API int cm_dial_call(cm_client_h handle, char*number, cm_call_type_e call
 			value = CM_ERROR_OPERATION_FAILED;
 		}
 	} else {
-		err("g_dbus_conn failed. error (%s)", error->message);
-		if (strstr(error->message, "No access rights")) {
-			err("PERMISSION_DENIED");
-			value = CM_ERROR_PERMISSION_DENIED;
-		} else {
-			value = CM_ERROR_OPERATION_FAILED;
+		if (error) {
+			err("g_dbus_conn failed. error (%s)", error->message);
+			if (strstr(error->message, "No access rights")) {
+				err("PERMISSION_DENIED");
+				value = CM_ERROR_PERMISSION_DENIED;
+			} else {
+				value = CM_ERROR_OPERATION_FAILED;
+			}
+			g_error_free(error);
 		}
-		g_error_free(error);
 	}
 
 	 g_variant_unref(dbus_result);
@@ -586,14 +588,16 @@ EXPORT_API int cm_reject_call(cm_client_h handle)
 			value = CM_ERROR_OPERATION_FAILED;
 		}
 	} else {
-		err("g_dbus_conn failed. error (%s)", error->message);
-		if (strstr(error->message, "No access rights")) {
-			err("PERMISSION_DENIED");
-			value = CM_ERROR_PERMISSION_DENIED;
-		} else {
-			value = CM_ERROR_OPERATION_FAILED;
+		if (error) {
+			err("g_dbus_conn failed. error (%s)", error->message);
+			if (strstr(error->message, "No access rights")) {
+				err("PERMISSION_DENIED");
+				value = CM_ERROR_PERMISSION_DENIED;
+			} else {
+				value = CM_ERROR_OPERATION_FAILED;
+			}
+			g_error_free(error);
 		}
-		g_error_free(error);
 	}
 
 	g_variant_unref(dbus_result);
@@ -1317,14 +1321,16 @@ EXPORT_API int cm_stop_alert(cm_client_h handle)
 			value = CM_ERROR_OPERATION_FAILED;
 		}
 	} else {
-		err("g_dbus_conn failed. error (%s)", error->message);
-		if (strstr(error->message, "No access rights")) {
-			err("PERMISSION_DENIED");
-			value = CM_ERROR_PERMISSION_DENIED;
-		} else {
-			value = CM_ERROR_OPERATION_FAILED;
+		if (error) {
+			err("g_dbus_conn failed. error (%s)", error->message);
+			if (strstr(error->message, "No access rights")) {
+				err("PERMISSION_DENIED");
+				value = CM_ERROR_PERMISSION_DENIED;
+			} else {
+				value = CM_ERROR_OPERATION_FAILED;
+			}
+			g_error_free(error);
 		}
-		g_error_free(error);
 	}
 
 	g_variant_unref(dbus_result);
@@ -1353,14 +1359,16 @@ EXPORT_API int cm_start_alert(cm_client_h handle)
 			value = CM_ERROR_OPERATION_FAILED;
 		}
 	} else {
-		err("g_dbus_conn failed. error (%s)", error->message);
-		if (strstr(error->message, "No access rights")) {
-			err("PERMISSION_DENIED");
-			value = CM_ERROR_PERMISSION_DENIED;
-		} else {
-			value = CM_ERROR_OPERATION_FAILED;
+		if (error) {
+			err("g_dbus_conn failed. error (%s)", error->message);
+			if (strstr(error->message, "No access rights")) {
+				err("PERMISSION_DENIED");
+				value = CM_ERROR_PERMISSION_DENIED;
+			} else {
+				value = CM_ERROR_OPERATION_FAILED;
+			}
+			g_error_free(error);
 		}
-		g_error_free(error);
 	}
 
 	g_variant_unref(dbus_result);
@@ -1648,14 +1656,16 @@ EXPORT_API int cm_get_call_status(cm_client_h handle, cm_call_status_e *call_sta
 			error_code = CM_ERROR_OPERATION_FAILED;
 		}
 	} else {
-		err("g_dbus_conn failed. error (%s)", error->message);
-		if (strstr(error->message, "No access rights")) {
-			err("PERMISSION_DENIED");
-			error_code = CM_ERROR_PERMISSION_DENIED;
-		} else {
-			error_code = CM_ERROR_OPERATION_FAILED;
+		if (error) {
+			err("g_dbus_conn failed. error (%s)", error->message);
+			if (strstr(error->message, "No access rights")) {
+				err("PERMISSION_DENIED");
+				error_code = CM_ERROR_PERMISSION_DENIED;
+			} else {
+				error_code = CM_ERROR_OPERATION_FAILED;
+			}
+			g_error_free(error);
 		}
-		g_error_free(error);
 	}
 
 	g_variant_unref(dbus_result);
@@ -1688,14 +1698,16 @@ EXPORT_API int cm_get_mute_status(cm_client_h handle, cm_mute_status_e *mute_sta
 			error_code = CM_ERROR_OPERATION_FAILED;
 		}
 	} else {
-		err("g_dbus_conn failed. error (%s)", error->message);
-		if (strstr(error->message, "No access rights")) {
-			err("PERMISSION_DENIED");
-			error_code = CM_ERROR_PERMISSION_DENIED;
-		} else {
-			error_code = CM_ERROR_OPERATION_FAILED;
+		if (error) {
+			err("g_dbus_conn failed. error (%s)", error->message);
+			if (strstr(error->message, "No access rights")) {
+				err("PERMISSION_DENIED");
+				error_code = CM_ERROR_PERMISSION_DENIED;
+			} else {
+				error_code = CM_ERROR_OPERATION_FAILED;
+			}
+			g_error_free(error);
 		}
-		g_error_free(error);
 	}
 
 	g_variant_unref(dbus_result);