From: KiseokChang Date: Tue, 18 Jul 2023 02:36:07 +0000 (+0900) Subject: fix warning from strndup() X-Git-Tag: accepted/tizen/unified/dev/20230726.120012^0 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=refs%2Fheads%2Ftizen;p=profile%2Fcommon%2Fapps%2Fnative%2Fsettings.git fix warning from strndup() - revert build option, Wno-stringop-overread Change-Id: Ie7e526f2e8c67bd5935be720350fe48b28d3a4d4 Signed-off-by: KiseokChang --- diff --git a/setting-ringtone/CMakeLists.txt b/setting-ringtone/CMakeLists.txt index 4b94664..cd00fd3 100755 --- a/setting-ringtone/CMakeLists.txt +++ b/setting-ringtone/CMakeLists.txt @@ -35,6 +35,7 @@ ENDIF("${ARCH}" STREQUAL "arm") ADD_DEFINITIONS("-DPREFIX=\"${CMAKE_INSTALL_PREFIX}\"") ADD_DEFINITIONS("-DSLP_DEBUG") ADD_DEFINITIONS("-shared") +ADD_DEFINITIONS("-Wno-stringop-overread") SET(CMAKE_EXE_LINKER_FLAGS "-Wl,--as-needed -Wl,--rpath=/usr/lib") diff --git a/setting-ringtone/src/setting-ringtone-main.c b/setting-ringtone/src/setting-ringtone-main.c index 95d36fd..9706a8d 100755 --- a/setting-ringtone/src/setting-ringtone-main.c +++ b/setting-ringtone/src/setting-ringtone-main.c @@ -351,10 +351,14 @@ static char *_get_default_filepath(SettingRingtoneData *ad) if (ad->default_substitution) return strndup(ad->default_substitution, PATH_MAX); + int maxpath = sizeof(ALERT_FILE_PATH_DEF); + if(maxpath > PATH_MAX) maxpath = PATH_MAX; if (ad->show_notification) - return strndup(ALERT_FILE_PATH_DEF, PATH_MAX); + return strndup(ALERT_FILE_PATH_DEF, maxpath); - return strndup(RINGTONE_FILE_PATH_DEF, PATH_MAX); + maxpath = sizeof(RINGTONE_FILE_PATH_DEF); + if(maxpath > PATH_MAX) maxpath = PATH_MAX; + return strndup(RINGTONE_FILE_PATH_DEF, maxpath); } static void _move_more_ctxpopup(SettingRingtoneData *ad)