From: Łukasz Stelmach <l.stelmach@samsung.com>
Date: Fri, 10 Sep 2021 18:02:53 +0000 (+0200)
Subject: WIP: handle error values from filp_open()
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=refs%2Fheads%2Fsandbox%2Flstelmach%2Flogger-handle-errors;p=platform%2Fkernel%2Flinux-tizen-modules.git

WIP: handle error values from filp_open()

Change-Id: I5a694555bcd082506330e08f48ed4b7043c4e120
---

diff --git a/kernel/logger.c b/kernel/logger.c
index 48dbf4a..811e745 100644
--- a/kernel/logger.c
+++ b/kernel/logger.c
@@ -484,10 +484,13 @@ static struct file *make_new_file(struct file *file)
 
 	nfile = filp_open(p, O_WRONLY, 0);
 	kfree(pbuf);
-	if (!nfile) {
+	if (IS_ERR_OR_NULL(nfile)) {
+		pr_err("filp_open(%s): %ld\n", pbuf, PTR_ERR(nfile));
+		kfree(pbuf);
 		return ERR_PTR(-EFAULT);
 	}
 
+	kfree(pbuf);
 	nwriter = nfile->private_data;
 	nwriter->prio = writer->prio;
 	nwriter->tag = kstrdup(writer->tag, GFP_KERNEL);