From: tranthanhtung2001 Date: Tue, 20 May 2025 01:35:22 +0000 (+0700) Subject: Fix USE_AFTER_FREE Critical Defect X-Git-Tag: accepted/tizen/unified/20250520.140703^0 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=refs%2Fheads%2Faccepted%2Ftizen_unified;p=platform%2Fcore%2Fsecurity%2Fprivilege-checker.git Fix USE_AFTER_FREE Critical Defect Change-Id: Ie1855944093a6f56d8d201fe3fc476d500b277c7 --- diff --git a/test/tc-privilege-info.c b/test/tc-privilege-info.c index 6059021..30ddf98 100644 --- a/test/tc-privilege-info.c +++ b/test/tc-privilege-info.c @@ -317,8 +317,7 @@ void __test_privilege_info_get_privacy_display() fail_cnt++; printf_red("FAIL: ret = %d, privacy_display = %s\n", ret, privacy_display); } - free(privacy_display); - privacy_display = NULL; + SafeFree(privacy_display); __tcinfo(goal, NEG_TC_PREFIX "__test_privilege_info_get_privacy_display with wrong privacy"); printf("WRONG privacy: http://tizen.org/privilege/account.read\n"); @@ -330,8 +329,7 @@ void __test_privilege_info_get_privacy_display() fail_cnt++; printf_red("FAIL: ret = %d, privacy_display = %s\n", ret, privacy_display); } - free(privacy_display); - privacy_display = NULL; + SafeFree(privacy_display); __tcinfo(goal, NEG_TC_PREFIX "__test_privilege_info_get_privacy_display with NULL parameter"); printf("NULL param\n"); @@ -343,7 +341,7 @@ void __test_privilege_info_get_privacy_display() fail_cnt++; printf_red("FAIL: ret = %d, privacy_display = %s\n", ret, privacy_display); } - free(privacy_display); + SafeFree(privacy_display); } void __test_privilege_info_get_privacy_list() @@ -413,9 +411,7 @@ void __test_privilege_info_get_privacy_by_privilege() int ret = privilege_info_get_privacy_by_privilege("http://tizen.org/privilege/apphistory.read", &privacy); __check_the_return_code('m', PRVMGR_ERR_NONE, ret); - - free(privacy); - privacy = NULL; + SafeFree(privacy); __print_line(); @@ -424,8 +420,7 @@ void __test_privilege_info_get_privacy_by_privilege() ret = privilege_info_get_privacy_by_privilege("http://tizen.org/privilege/internet", &privacy); __check_the_return_code('m', PRVMGR_ERR_INVALID_PARAMETER, ret); - - free(privacy); + SafeFree(privacy); __print_line(); } @@ -440,8 +435,7 @@ void __test_privilege_info_get_privilege_display_name() expected_display_name = "IDS_TPLATFORM_BODY_READING_ACCOUNTS"; ret = privilege_info_get_privilege_display_name("http://tizen.org/privilege/account.read", &display_name); __check_get_privilege_display_name_result(PRVMGR_ERR_NONE, ret, display_name, expected_display_name); - free(display_name); - display_name = NULL; + SafeFree(display_name); expected_display_name = NULL; __print_line(); @@ -449,8 +443,7 @@ void __test_privilege_info_get_privilege_display_name() printf("privilege : http://tizen.org/privilege/badge.admin\n"); ret = privilege_info_get_privilege_display_name("http://tizen.org/privilege/badge.admin", &display_name); __check_get_privilege_display_name_result(PRVMGR_ERR_NONE, ret, display_name, expected_display_name); - free(display_name); - display_name = NULL; + SafeFree(display_name); expected_display_name = NULL; __print_line(); @@ -458,8 +451,7 @@ void __test_privilege_info_get_privilege_display_name() printf("privilege : http://tizen.org/privilege/accousdfsdnt.resdfsdfad\n"); ret = privilege_info_get_privilege_display_name("http://tizen.org/privilege/accousdfsdnt.resdfsdfad", &display_name); __check_get_privilege_display_name_result(PRVMGR_ERR_NONE, ret, display_name, expected_display_name); - free(display_name); - display_name = NULL; + SafeFree(display_name); expected_display_name = NULL; __print_line(); @@ -467,7 +459,7 @@ void __test_privilege_info_get_privilege_display_name() printf("privilege : NULL\n"); ret = privilege_info_get_privilege_display_name(NULL, &display_name); __check_get_privilege_display_name_result(PRVMGR_ERR_INVALID_PARAMETER, ret, display_name, expected_display_name); - free(display_name); + SafeFree(display_name); __print_line(); } @@ -482,8 +474,7 @@ void __test_privilege_info_get_privilege_description() expected_description = "IDS_TPLATFORM_BODY_THIS_APPLICATION_CAN_READ_ACCOUNTS"; ret = privilege_info_get_privilege_description("http://tizen.org/privilege/account.read", &description); __check_get_privilege_description_result(PRVMGR_ERR_NONE, ret, description, expected_description); - free(description); - description = NULL; + SafeFree(description); __print_line(); __tcinfo(goal, NEG_TC_PREFIX "__test_privilege_info_get_privilege_description with wrong parameter"); @@ -491,8 +482,7 @@ void __test_privilege_info_get_privilege_description() expected_description = NULL; ret = privilege_info_get_privilege_description("http://tizen.org/privilege/badge.admin", &description); __check_get_privilege_description_result(PRVMGR_ERR_NONE, ret, description, expected_description); - free(description); - description = NULL; + SafeFree(description); __print_line(); __tcinfo(goal, NEG_TC_PREFIX "__test_privilege_info_get_privilege_description with invalid parameter"); @@ -500,14 +490,13 @@ void __test_privilege_info_get_privilege_description() expected_description = NULL; ret = privilege_info_get_privilege_description("http://tizen.org/privilege/accousdfsdnt.resdfsdfad", &description); __check_get_privilege_description_result(PRVMGR_ERR_NONE, ret, description, expected_description); - free(description); - description = NULL; + SafeFree(description); __print_line(); __tcinfo(goal, NEG_TC_PREFIX "__test_privilege_info_get_privilege_description with null parameter"); ret = privilege_info_get_privilege_description(NULL, &description); __check_get_privilege_description_result(PRVMGR_ERR_INVALID_PARAMETER, ret, description, expected_description); - free(description); + SafeFree(description); free(expected_description); __print_line(); } @@ -967,8 +956,7 @@ void __test_privilege_info_get_privilege_description_by_package_type() PRVMGR_PACKAGE_TYPE_CORE, &description); __check_get_privilege_description_result(PRVMGR_ERR_NONE, ret, description, expected_description); - free(description); - description = NULL; + SafeFree(description); __print_line(); __tcinfo(goal, NEG_TC_PREFIX "__test_privilege_info_get_privilege_description_by_package_type with invalid privilege"); @@ -980,7 +968,7 @@ void __test_privilege_info_get_privilege_description_by_package_type() PRVMGR_PACKAGE_TYPE_CORE, &description); __check_get_privilege_description_result(PRVMGR_ERR_NO_EXIST_PRIVILEGE, ret, description, expected_description); - free(description); + SafeFree(description); __print_line(); __tcinfo(goal, NEG_TC_PREFIX "__test_privilege_info_get_privilege_description_by_package_type with null privilege"); @@ -992,7 +980,7 @@ void __test_privilege_info_get_privilege_description_by_package_type() PRVMGR_PACKAGE_TYPE_CORE, &description); __check_get_privilege_description_result(PRVMGR_ERR_INVALID_PARAMETER, ret, description, expected_description); - free(description); + SafeFree(description); __print_line(); __tcinfo(goal, NEG_TC_PREFIX "__test_privilege_info_get_privilege_description_by_package_type with PRVMGR_PACKAGE_TYPE_NONE"); @@ -1004,7 +992,7 @@ void __test_privilege_info_get_privilege_description_by_package_type() PRVMGR_PACKAGE_TYPE_NONE, &description); __check_get_privilege_description_result(PRVMGR_ERR_INVALID_PARAMETER, ret, description, expected_description); - free(description); + SafeFree(description); __print_line(); } @@ -1025,8 +1013,7 @@ void __test_privilege_info_get_privilege_display_name_by_package_type() PRVMGR_PACKAGE_TYPE_CORE, &display_name); __check_get_privilege_display_name_result(PRVMGR_ERR_NONE, ret, display_name, expected_display_name); - free(display_name); - display_name = NULL; + SafeFree(display_name); expected_display_name = NULL; __print_line(); @@ -1039,7 +1026,7 @@ void __test_privilege_info_get_privilege_display_name_by_package_type() PRVMGR_PACKAGE_TYPE_CORE, &display_name); __check_get_privilege_display_name_result(PRVMGR_ERR_NO_EXIST_PRIVILEGE, ret, display_name, expected_display_name); - free(display_name); + SafeFree(display_name); __print_line(); __tcinfo(goal, NEG_TC_PREFIX "__test_privilege_info_get_privilege_display_name_by_package_type with null privilege"); @@ -1047,7 +1034,7 @@ void __test_privilege_info_get_privilege_display_name_by_package_type() printf("privilege : NULL\n"); ret = privilege_info_get_privilege_display_name_by_package_type(NULL, "2.3", PRVMGR_PACKAGE_TYPE_CORE, &display_name); __check_get_privilege_display_name_result(PRVMGR_ERR_INVALID_PARAMETER, ret, display_name, expected_display_name); - free(display_name); + SafeFree(display_name); __print_line(); __tcinfo(goal, NEG_TC_PREFIX "__test_privilege_info_get_privilege_display_name_by_package_type with PRVMGR_PACKAGE_TYPE_NONE"); @@ -1055,7 +1042,7 @@ void __test_privilege_info_get_privilege_display_name_by_package_type() printf("privilege : NULL\n"); ret = privilege_info_get_privilege_display_name_by_package_type(NULL, "2.3", PRVMGR_PACKAGE_TYPE_NONE, &display_name); __check_get_privilege_display_name_result(PRVMGR_ERR_INVALID_PARAMETER, ret, display_name, expected_display_name); - free(display_name); + SafeFree(display_name); __print_line(); }