From: Krishna Kant Jaju Date: Fri, 16 Jun 2023 07:31:39 +0000 (+0530) Subject: Coverity issue fix, check invalid map value access X-Git-Tag: accepted/tizen/unified/20230705.131030^0 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=refs%2Fheads%2Faccepted%2Ftizen_unified;p=platform%2Fcore%2Faccount%2Ffido-asm.git Coverity issue fix, check invalid map value access Change-Id: I107965a242e30f8573855ffc5a1ed157f246689e Signed-off-by: Krishna Kant Jaju --- diff --git a/common/uafv1tlvutil/src/TlvEncoderFactory.cpp b/common/uafv1tlvutil/src/TlvEncoderFactory.cpp index 98d39a5..5dcf46e 100755 --- a/common/uafv1tlvutil/src/TlvEncoderFactory.cpp +++ b/common/uafv1tlvutil/src/TlvEncoderFactory.cpp @@ -39,7 +39,11 @@ TlvEncoderFactory::getTlvEncoderById(int id) RET_IF_FAIL(__encoderTable != NULL, NULL); _INFO(""); - return __encoderTable->find(id)->second; + + if(__encoderTable->find(id) != __encoderTable->end()) + return __encoderTable->find(id)->second; + + return NULL; } TlvEncoderFactory::TlvEncoderFactory(void) {} diff --git a/packaging/fido-asm.spec b/packaging/fido-asm.spec index 483a551..8d0c50a 100755 --- a/packaging/fido-asm.spec +++ b/packaging/fido-asm.spec @@ -1,7 +1,7 @@ Name: fido-asm Summary: Tizen FIDO Reference ASM -Version: 0.0.1 +Version: 0.0.2 Release: 1 Group: Social & Content/Other License: Apache-2.0 diff --git a/server/auth_discovery/src/BtADProvider.cpp b/server/auth_discovery/src/BtADProvider.cpp index 8823086..a4831b0 100755 --- a/server/auth_discovery/src/BtADProvider.cpp +++ b/server/auth_discovery/src/BtADProvider.cpp @@ -214,7 +214,10 @@ BtAdProvider::getStubFromCache(int mappedIdx) return NULL; } - return __stubCache->find(mappedIdx)->second; + if(__stubCache->find(mappedIdx) != __stubCache->end()) + return __stubCache->find(mappedIdx)->second; + + return NULL; } BtAdProvider::~BtAdProvider(void) diff --git a/server/auth_discovery/src/BtCon.cpp b/server/auth_discovery/src/BtCon.cpp index cc9940f..6eb59e3 100755 --- a/server/auth_discovery/src/BtCon.cpp +++ b/server/auth_discovery/src/BtCon.cpp @@ -305,7 +305,9 @@ BtCon::sendReqSync(StringMap *reqData) RET_IF_FAIL(__sock->socket_fd != -1, NULL); __resp = NULL; - std::string reqTlvB64 = (reqData->find(RA_QUERY_KEY_REQUEST)->second); + std::string reqTlvB64 = ""; + if(reqData->find(RA_QUERY_KEY_REQUEST) != reqData->end()) + reqTlvB64 = reqData->find(RA_QUERY_KEY_REQUEST)->second; char *reqTlvB64Copy = strdup(reqTlvB64.c_str()); __waitLoop = g_main_loop_new(NULL, FALSE);