From: Jongmin Lee Date: Mon, 7 Oct 2019 08:43:53 +0000 (+0900) Subject: Check return value of vconf function (detected by coverity tool) X-Git-Tag: submit/tizen/20191007.211537^0 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=refs%2Fheads%2Faccepted%2Ftizen_5.5_unified_wearable_hotfix;p=profile%2Fwearable%2Fapps%2Fnative%2Faccessibility-setting.git Check return value of vconf function (detected by coverity tool) Change-Id: Ia5752d23aa37bd1051dd92db01d04e198e2798ea --- diff --git a/src/setting-accessibility-vision.c b/src/setting-accessibility-vision.c index 76ab7ae..40babb2 100644 --- a/src/setting-accessibility-vision.c +++ b/src/setting-accessibility-vision.c @@ -89,7 +89,8 @@ __setting_accessibility_vision_itc_content_get_cb(void *data, Evas_Object *obj, switch (pItemData->menu) { case SETTING_ACCESSIBILITY_VISION_SCREEN_READER: - vconf_get_bool(VCONFKEY_SETAPPL_ACCESSIBILITY_TTS, &vconfValue); + if (vconf_get_bool(VCONFKEY_SETAPPL_ACCESSIBILITY_TTS, &vconfValue) < 0) + ERR("failed to get vconf key %s", VCONFKEY_SETAPPL_ACCESSIBILITY_TTS); DBG("vconf_get_bool(VCONFKEY_SETAPPL_ACCESSIBILITY_TTS)=%d.", vconfValue); break; @@ -133,7 +134,8 @@ __setting_accessibility_vision_screen_reader_vconf_changed_cb(keynode_t *key, vo access_ret_if(!pItemData); int vconfValue = 0; - vconf_get_bool(VCONFKEY_SETAPPL_ACCESSIBILITY_TTS, &vconfValue); + if (vconf_get_bool(VCONFKEY_SETAPPL_ACCESSIBILITY_TTS, &vconfValue) < 0) + ERR("failed to set vconf key %s", VCONFKEY_SETAPPL_ACCESSIBILITY_TTS); DBG("vconf_get_bool(VCONFKEY_SETAPPL_ACCESSIBILITY_TTS)=%d.", vconfValue); elm_check_state_set(pItemData->pObj_check, (vconfValue) ? EINA_TRUE : EINA_FALSE); @@ -150,7 +152,8 @@ __setting_accessibility_vision_naviframe_pop_cb(void *data, Elm_Object_Item *pOb static void __setting_accessibility_vision_layout_del_cb(void *data , Evas *e, Evas_Object *obj, void *event_info) { - vconf_ignore_key_changed(VCONFKEY_SETAPPL_ACCESSIBILITY_TTS, __setting_accessibility_vision_screen_reader_vconf_changed_cb); + if (vconf_ignore_key_changed(VCONFKEY_SETAPPL_ACCESSIBILITY_TTS, __setting_accessibility_vision_screen_reader_vconf_changed_cb) < 0) + ERR("failed to vconf_ignore_key_changed %s", VCONFKEY_SETAPPL_ACCESSIBILITY_TTS); } Evas_Object* @@ -193,7 +196,8 @@ setting_accessibility_vision_create_view(void *data) if (pItemData) { pItemData->menu = SETTING_ACCESSIBILITY_VISION_SCREEN_READER; pItemData->pObjItem = elm_genlist_item_append(pObj_genlist, itc_1text_1icon, pItemData, NULL, ELM_GENLIST_ITEM_NONE, __setting_accessibility_vision_screen_reader_item_select_cb, pItemData); - vconf_notify_key_changed(VCONFKEY_SETAPPL_ACCESSIBILITY_TTS, __setting_accessibility_vision_screen_reader_vconf_changed_cb, pItemData); + if (vconf_notify_key_changed(VCONFKEY_SETAPPL_ACCESSIBILITY_TTS, __setting_accessibility_vision_screen_reader_vconf_changed_cb, pItemData) < 0) + ERR("failed to vconf_notify_key_changed %s", VCONFKEY_SETAPPL_ACCESSIBILITY_TTS); } elm_genlist_item_class_free(itc_title);