From: ws29.jung Date: Tue, 14 Apr 2020 07:39:33 +0000 (+0900) Subject: [Addon] Fix showMessageBox function X-Git-Tag: accepted/tizen/unified/20200427.125816^2 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=refs%2Fchanges%2F97%2F230797%2F2;p=platform%2Fframework%2Fweb%2Fwrtjs.git [Addon] Fix showMessageBox function Old version of Electron only had 'showMessageBox' function, and it handled sync and async mode under binded C++ function. Now new Electron export 'showMessageBoxSync' function separatly and it works as sync mode of old 'showMessageBox'. To handle both functions with one source code, this patch makes addonapi method to use logical function fallback. Change-Id: I97c06ebff302c7e3770166fe162c53ea251f05b0 Signed-off-by: ws29.jung --- diff --git a/wrt_app/addon/browser/modules/window.js b/wrt_app/addon/browser/modules/window.js index c7a92f2..44e779d 100644 --- a/wrt_app/addon/browser/modules/window.js +++ b/wrt_app/addon/browser/modules/window.js @@ -10,11 +10,12 @@ module.exports = { showMessageBox: function (winId, options) { let window = TopLevelWindow.fromId(winId); - dialog.showMessageBox(window, options, null); + let showMessageBox = (dialog.showMessageBoxSync || dialog.showMessageBox); + showMessageBox(window, options); }, show: function (winId) { let window = TopLevelWindow.fromId(winId); window.show(); } -} \ No newline at end of file +}