From: Janusz Majnert <j.majnert@samsung.com>
Date: Wed, 21 Oct 2015 08:35:54 +0000 (+0200)
Subject: Fix compiler warning in HistoryUI
X-Git-Tag: accepted/tizen/tv/20151022.010509^0
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=refs%2Fchanges%2F96%2F49896%2F3;p=profile%2Ftv%2Fapps%2Fweb%2Fbrowser.git

Fix compiler warning in HistoryUI

[Issue]        N/A
[Problem]      Compilation warning about unused variables and no return statement
[Solution]     Remove unused variables, change method return type
[Verification] Build the project and verify that there are no warnings from
               HistoryUI

Also changed one reinterpret_cast into a static_cast.

Change-Id: I83fe252409475ef0918978d1d30560f6ab4f85a7
---

diff --git a/services/HistoryUI/HistoryUI.cpp b/services/HistoryUI/HistoryUI.cpp
index 094f04c..619d4a1 100644
--- a/services/HistoryUI/HistoryUI.cpp
+++ b/services/HistoryUI/HistoryUI.cpp
@@ -104,7 +104,7 @@ Evas_Object* HistoryUI::getContent()
     return m_history_layout;
 }
 
-Evas_Object* HistoryUI::createHistoryUILayout(Evas_Object* parent)
+void HistoryUI::createHistoryUILayout(Evas_Object* parent)
 {
     BROWSER_LOGD("[%s:%d] ", __PRETTY_FUNCTION__, __LINE__);
     elm_theme_extension_add(nullptr, m_edjFilePath.c_str());
@@ -301,10 +301,10 @@ void HistoryUI::clearItems()
     _history_item_data.clear();
 }
 
-void HistoryUI::_history_item_clicked_cb(void *data, Evas_Object *obj, void *event_info)
+void HistoryUI::_history_item_clicked_cb(void *data, Evas_Object*, void*)
 {
     BROWSER_LOGD("[%s:%d] ", __PRETTY_FUNCTION__, __LINE__);
-    HistoryItemData * itemData = reinterpret_cast<HistoryItemData *>(data);
+    HistoryItemData * itemData = static_cast<HistoryItemData *>(data);
     itemData->historyUI->historyItemClicked(itemData->item);
 }
 
diff --git a/services/HistoryUI/HistoryUI.h b/services/HistoryUI/HistoryUI.h
index 859eddc..94579ff 100644
--- a/services/HistoryUI/HistoryUI.h
+++ b/services/HistoryUI/HistoryUI.h
@@ -53,7 +53,7 @@ public:
     boost::signals2::signal<void (std::shared_ptr<tizen_browser::services::HistoryItem>)> historyDeleteClicked;
 private:
     void clearItems();
-    Evas_Object* createHistoryUILayout(Evas_Object* parent);
+    void createHistoryUILayout(Evas_Object* parent);
     Elm_Gengrid_Item_Class* crateItemClass();
     static char* _grid_text_get(void *data, Evas_Object *obj, const char *part);
     static Evas_Object * _history_grid_content_get(void *data, Evas_Object *obj, const char *part);