From: JinYong Park Date: Thu, 19 Oct 2017 12:07:33 +0000 (+0900) Subject: eolian: fix incorrect doxygen param generation X-Git-Tag: accepted/tizen/unified/20171027.152001~3 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=refs%2Fchanges%2F95%2F156695%2F2;p=platform%2Fupstream%2Fefl.git eolian: fix incorrect doxygen param generation The first param on methods was skipped for some reason. @fix it is opensource patch https://phab.enlightenment.org/rEFL1a34d89d20c3b90b103481a501764eec522d35aa Change-Id: If3d5d8b05d901a99e2338b6a775ede49b01cea2c Signed-off-by: JinYong Park --- diff --git a/src/bin/eolian/docs_generator.c b/src/bin/eolian/docs_generator.c index 7a8202a..3044433 100644 --- a/src/bin/eolian/docs_generator.c +++ b/src/bin/eolian/docs_generator.c @@ -385,11 +385,6 @@ docs_generate_function(const Eolian_Function *fid, Eolian_Function_Type ftype, if (ftype == EOLIAN_METHOD) { itr = eolian_function_parameters_get(fid); - if (!itr || !eina_iterator_next(itr, (void**)&par)) - { - eina_iterator_free(itr); - itr = NULL; - } } else { @@ -402,7 +397,7 @@ docs_generate_function(const Eolian_Function *fid, Eolian_Function_Type ftype, } } - if (itr && !eina_iterator_next(itr, (void**)&par)) + if (!itr || !eina_iterator_next(itr, (void**)&par)) { eina_iterator_free(itr); itr = NULL; diff --git a/src/tests/eolian/data/class_simple_ref_eo.h b/src/tests/eolian/data/class_simple_ref_eo.h index 6a0dac1..fe35d86 100644 --- a/src/tests/eolian/data/class_simple_ref_eo.h +++ b/src/tests/eolian/data/class_simple_ref_eo.h @@ -53,6 +53,7 @@ EOAPI void evas_obj_simple_b_set(void); /** * @brief comment foo * + * @param[in] a a * @param[in,out] b * @param[out] c * diff --git a/src/tests/eolian/data/class_simple_ref_legacy.h b/src/tests/eolian/data/class_simple_ref_legacy.h index 8fd6345..6397c9f 100644 --- a/src/tests/eolian/data/class_simple_ref_legacy.h +++ b/src/tests/eolian/data/class_simple_ref_legacy.h @@ -44,6 +44,7 @@ EAPI void evas_object_simple_b_set(Class_Simple *obj); /** * @brief comment foo * + * @param[in] a a * @param[in,out] b * @param[out] c * diff --git a/src/tests/eolian/data/docs_ref.h b/src/tests/eolian/data/docs_ref.h index a134905..dd9cd8f 100644 --- a/src/tests/eolian/data/docs_ref.h +++ b/src/tests/eolian/data/docs_ref.h @@ -108,6 +108,7 @@ EOAPI int docs_prop_get(void); /** * @brief Method documentation. * + * @param[in] a Param documentation. * @param[out] b * @param[out] c Another param documentation. * diff --git a/src/tests/eolian/data/docs_ref_legacy.h b/src/tests/eolian/data/docs_ref_legacy.h index e804e3f..33314da 100644 --- a/src/tests/eolian/data/docs_ref_legacy.h +++ b/src/tests/eolian/data/docs_ref_legacy.h @@ -105,6 +105,7 @@ EAPI int docs_prop_get(const Docs *obj); /** * @brief Method documentation. * + * @param[in] a Param documentation. * @param[out] b * @param[out] c Another param documentation. *