From: Suyeon Hwang <stom.hwang@samsung.com>
Date: Thu, 30 Sep 2021 01:44:37 +0000 (+0900)
Subject: Reorder mutex to prevent deadlock
X-Git-Tag: submit/tizen/20210930.015514^0
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=refs%2Fchanges%2F93%2F264793%2F1;p=platform%2Fcore%2Fuifw%2Ftts.git

Reorder mutex to prevent deadlock

Change-Id: Iecb2765a2362d7f3407a26c4e3399fff0fe10f57
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
---

diff --git a/server/ttsd_player.c b/server/ttsd_player.c
index 485668a2..df2c090c 100644
--- a/server/ttsd_player.c
+++ b/server/ttsd_player.c
@@ -865,16 +865,15 @@ static void __play_thread(void *data, Ecore_Thread *thread)
 				ret = audio_out_prepare(g_audio_h);
 				if (AUDIO_IO_ERROR_NONE != ret) {
 					SLOG(LOG_ERROR, tts_tag(), "[Player ERROR] Fail to prepare audio : %d", ret);
-					pthread_mutex_lock(&g_player_control_mutex);
-					g_playing_info = NULL;
-					pthread_mutex_unlock(&g_player_control_mutex);
-
 					/* unset volume policy, volume will be 100% */
 					__unset_policy_for_playing();
 
 					ttsd_data_clear_sound_data(&sound_data);
 
 					pthread_mutex_unlock(&g_play_thread_mutex);
+					pthread_mutex_lock(&g_player_control_mutex);
+					g_playing_info = NULL;
+					pthread_mutex_unlock(&g_player_control_mutex);
 					return;
 				}
 				SLOG(LOG_DEBUG, tts_tag(), "[Player SUCCESS] Prepare audio");