From: Youngjae Cho <y0.cho@samsung.com>
Date: Fri, 19 Apr 2024 02:46:07 +0000 (+0900)
Subject: halapi: Disable dependency checking between hal-api
X-Git-Tag: accepted/tizen/unified/20240611.122614~20
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=refs%2Fchanges%2F90%2F309990%2F4;p=platform%2Fhal%2Fapi%2Fcommon.git

halapi: Disable dependency checking between hal-api

Temporarily disable it. For now, it is unclear that dependency checking
is necessary. Because, those hal-api header and manifest.xml aren't
managed by ACR process so they could be transformed anyhow, breaking
dependency. Currently, our policy has no specification that force them
to think about and comply with dependency among hal-apis.

Change-Id: Iab1fc46674e4af0e0b6771c630d6e1a093dda8f9
Signed-off-by: Youngjae Cho <y0.cho@samsung.com>
---

diff --git a/src/hal-api-compatibility-checker.c b/src/hal-api-compatibility-checker.c
index b544db2..9423093 100644
--- a/src/hal-api-compatibility-checker.c
+++ b/src/hal-api-compatibility-checker.c
@@ -149,7 +149,12 @@ static void make_compatibility_manifest_info(void *data, void *user_data)
 	halcc_hal *hal;
 	const char *hal_name = NULL;
 	int manifest_major, manifest_minor;
-	halcc_dependency_state_e state;
+	/**
+	 * FIXME:
+	 * Temporarily disable dependency checking. See the below FIXME.
+	 *
+	 * halcc_dependency_state_e state;
+	 */
 	int ret;
 	const char *error_desc = NULL;
 	struct compatibility_info *manifest_info = NULL;
@@ -180,11 +185,20 @@ static void make_compatibility_manifest_info(void *data, void *user_data)
 		return;
 	}
 
-
-	if (halcc_hal_get_dependency_state(hal, &state) != 0) {
-		error_desc = "Failed to resolve dependency";
-		goto out;
-	}
+	/**
+	 * FIXME:
+	 * Temporarily disable it. For now, it is unclear that
+	 * this dependency checking is necessary. Because, those hal-api
+	 * header and manifest.xml aren't managed by ACR process so they
+	 * could be transformed anyhow, breaking dependency. Currently,
+	 * our policy has no such specification that force them to think
+	 * about and comply with dependency among hal-apis.
+	 *
+	 * if (halcc_hal_get_dependency_state(hal, &state) != 0) {
+	 * 	error_desc = "Failed to resolve dependency";
+	 * 	goto out;
+	 * }
+	 */
 
 	if (halcc_hal_get_version(hal, &manifest_major, &manifest_minor, NULL) < 0) {
 		error_desc = "Invalid manifest version";
@@ -364,7 +378,17 @@ static int load_hal_manifest(struct compatibility_info *manifest_info, int load_
 	if (ret < 0)
 		goto out;
 
-	halcc_manifest_validate_hal_dependency(manifest);
+	/**
+	 * FIXME:
+	 * Temporarily disable it. For now, it is unclear that
+	 * this dependency checking is necessary. Because, those hal-api
+	 * header and manifest.xml aren't managed by ACR process so they
+	 * could be transformed anyhow, breaking dependency. Currently,
+	 * our policy has no such specification that force them to think
+	 * about and comply with dependency among hal-apis.
+	 *
+	 * halcc_manifest_validate_hal_dependency(manifest);
+	 */
 
 	halcc_manifest_foreach_hal(manifest, make_compatibility_manifest_info, manifest_info);