From: Changgyu Choi <changyu.choi@samsung.com>
Date: Fri, 16 May 2025 07:37:47 +0000 (+0900)
Subject: Fix variable shadowing
X-Git-Tag: accepted/tizen/unified/20250516.202941~1
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=refs%2Fchanges%2F88%2F324388%2F1;p=platform%2Fcore%2Fappfw%2Funited-service.git

Fix variable shadowing

-Werror=shadow added.

Change-Id: Id9f223b3cde006f7e0d2dc543ac813a30d340fae
Signed-off-by: Changgyu Choi <changyu.choi@samsung.com>
---

diff --git a/CMakeLists.txt b/CMakeLists.txt
index 9594845..d5d2164 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -7,11 +7,11 @@ SET(PC_VERSION "${FULLVER}")
 SET(PC_REQUIRED "capi-base-common bundle tizen-core")
 SET(PC_LDFLAGS "-lunited-service")
 
-SET(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -Wl,-zdefs -fvisibility=hidden -g -Wall -Werror -fpic")
+SET(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -Wl,-zdefs -fvisibility=hidden -g -Wall -Werror -Werror=shadow -fpic")
 SET(CMAKE_C_FLAGS_DEBUG "-O0 -g")
 SET(CMAKE_C_FLAGS_RELEASE "-O2")
 
-SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} ${EXTRA_C_FLAGS} -std=c++23")
+SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} ${EXTRA_C_FLAGS} -Werror -Werror=shadow -std=c++23")
 SET(CMAKE_CXX_FLAGS_DEBUG "-O0 -g")
 SET(CMAKE_CXX_FLAGS_RELEASE "-O2")
 
diff --git a/src/service.cc b/src/service.cc
index 23a0404..c269edf 100644
--- a/src/service.cc
+++ b/src/service.cc
@@ -296,7 +296,7 @@ void Service::StopMonitoring() {
 }
 
 void Service::NotifyStateChanged() {
-  auto* args = new ServiceStateChangedEventArgs(this, state_);
+  auto* event_args = new ServiceStateChangedEventArgs(this, state_);
   g_idle_add(
       [](gpointer user_data) {
         auto* args = static_cast<ServiceStateChangedEventArgs*>(user_data);
@@ -306,7 +306,7 @@ void Service::NotifyStateChanged() {
         delete args;
         return G_SOURCE_REMOVE;
       },
-      args);
+      event_args);
 }
 
 }  // namespace tizen_base