From: Inki Dae Date: Wed, 11 Sep 2024 02:10:51 +0000 (+0900) Subject: task_manger: fix coverity issue X-Git-Tag: accepted/tizen/unified/20240911.104743^0 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=refs%2Fchanges%2F85%2F317485%2F2;p=platform%2Fcore%2Fapi%2Fsingleo.git task_manger: fix coverity issue Fix coverity issue - CID 1789482 - Data race condition by making sure locking before pusing a new thread to _threads. Change-Id: I94d142822972e057ba7ba9681c1c582589d9a503 Signed-off-by: Inki Dae --- diff --git a/services/task_manager/src/TaskManager.cpp b/services/task_manager/src/TaskManager.cpp index 3f5ccd5..df0d8d1 100644 --- a/services/task_manager/src/TaskManager.cpp +++ b/services/task_manager/src/TaskManager.cpp @@ -291,6 +291,9 @@ void TaskManager::run() // TODO. consider for multiple sources later. n->setInputBuffer(inputBuffer); + + std::lock_guard lock(_thread_mutex); + _threads.push(make_shared(&TaskManager::threadCb, this, std::ref(n))); _is_thread_created.insert(n); }