From: SangHyeon Jade Lee Date: Wed, 22 Nov 2017 05:12:00 +0000 (+0900) Subject: genlist: fix item calculation performance issue X-Git-Tag: accepted/tizen/4.0/unified/20171124.063607^0 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=refs%2Fchanges%2F85%2F161185%2F1;p=platform%2Fupstream%2Felementary.git genlist: fix item calculation performance issue in calc(), we only need to process first viewport items, but currently it forcely calculate block sized items in every single calc() funciton calls because of || operator. it must be changed as && operator for orignal purpose. Change-Id: If57081046d67c09d66c360dbbb75b31101ecc1e6 Signed-off-by: SangHyeon Jade Lee --- diff --git a/src/mobile_lib/elm_genlist.c b/src/mobile_lib/elm_genlist.c index 69a7305..b4d4912 100644 --- a/src/mobile_lib/elm_genlist.c +++ b/src/mobile_lib/elm_genlist.c @@ -1432,7 +1432,7 @@ _calc(void *data) // TIZEN_ONLY(20150828) : Calculate item which position on viewport area while (sd->queue && - ((sd->viewport_h > processed_size) || (cnt < MAX_ITEMS_PER_BLOCK))) + ((sd->viewport_h > processed_size) && (cnt < MAX_ITEMS_PER_BLOCK))) { Elm_Gen_Item *tmp; tmp = eina_list_data_get(sd->queue);