From: Sangchul Lee <sc11.lee@samsung.com>
Date: Wed, 1 Feb 2023 08:51:01 +0000 (+0900)
Subject: webrtc_stats: Add null check code before calling gst_structure_foreach()
X-Git-Tag: accepted/tizen/7.0/unified/20230213.171744~2
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=refs%2Fchanges%2F82%2F287882%2F1;p=platform%2Fcore%2Fapi%2Fwebrtc.git

webrtc_stats: Add null check code before calling gst_structure_foreach()

It is to avoid printing warning message from a console.

[Version] 0.3.285
[Issue type] Improvement

Change-Id: I52f0c9ad3f7c218b5af9d70706625a1e7848fcbb
---

diff --git a/packaging/capi-media-webrtc.spec b/packaging/capi-media-webrtc.spec
index e9889e5d..26ec27fc 100644
--- a/packaging/capi-media-webrtc.spec
+++ b/packaging/capi-media-webrtc.spec
@@ -1,6 +1,6 @@
 Name:       capi-media-webrtc
 Summary:    A WebRTC library in Tizen Native API
-Version:    0.3.284
+Version:    0.3.285
 Release:    0
 Group:      Multimedia/API
 License:    Apache-2.0
diff --git a/src/webrtc_stats.c b/src/webrtc_stats.c
index 8b9d1f8c..6f256e49 100644
--- a/src/webrtc_stats.c
+++ b/src/webrtc_stats.c
@@ -485,12 +485,16 @@ static void __stats_inbound_rtp_invoke_callback(const GstStructure *s, webrtc_st
 		NULL);
 
 	stats_userdata.export = false; /* to skip invoking callback stats below */
-	LOG_DEBUG("gst-rtpjitterbuffer-stats ---> ");
-	gst_structure_foreach(rtpjitterbuffer_stats, __stats_field_foreach_cb, &stats_userdata);
+	if (rtpjitterbuffer_stats) {
+		LOG_DEBUG("gst-rtpjitterbuffer-stats ---> ");
+		gst_structure_foreach(rtpjitterbuffer_stats, __stats_field_foreach_cb, &stats_userdata);
+	}
 	if (user_data->exit)
 		return;
-	LOG_DEBUG("gst-rtpsource-stats ---> ");
-	gst_structure_foreach(rtpsource_stats, __stats_field_foreach_cb, &stats_userdata);
+	if (rtpsource_stats) {
+		LOG_DEBUG("gst-rtpsource-stats ---> ");
+		gst_structure_foreach(rtpsource_stats, __stats_field_foreach_cb, &stats_userdata);
+	}
 }
 
 static void __stats_outbound_rtp_invoke_callback(const GstStructure *s, webrtc_stats_type_e type, stats_field_s **fields_list, promise_userdata_s *user_data)
@@ -508,8 +512,10 @@ static void __stats_outbound_rtp_invoke_callback(const GstStructure *s, webrtc_s
 
 	stats_userdata.export = false; /* to skip invoking callback stats below */
 	gst_structure_get(s, "gst-rtpsource-stats", GST_TYPE_STRUCTURE, &rtpsource_stats, NULL);
-	LOG_DEBUG("gst-rtpsource-stats ---> ");
-	gst_structure_foreach(rtpsource_stats, __stats_field_foreach_cb, &stats_userdata);
+	if (rtpsource_stats) {
+		LOG_DEBUG("gst-rtpsource-stats ---> ");
+		gst_structure_foreach(rtpsource_stats, __stats_field_foreach_cb, &stats_userdata);
+	}
 }
 
 static void __stats_remote_inbound_rtp_invoke_callback(const GstStructure *s, webrtc_stats_type_e type, stats_field_s **fields_list, promise_userdata_s *user_data)
@@ -519,7 +525,6 @@ static void __stats_remote_inbound_rtp_invoke_callback(const GstStructure *s, we
 
 	LOG_DEBUG_ENTER();
 
-	/* FIXME: type of 'packets-lost(int)' should be fixed.*/
 	gst_structure_foreach(s, __stats_field_foreach_cb, &stats_userdata);
 }