From: jinbong.lee Date: Thu, 12 Jun 2025 06:11:42 +0000 (+0900) Subject: e_view_smart : Add null checks X-Git-Tag: accepted/tizen/unified/20250613.040658~21 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=refs%2Fchanges%2F79%2F325579%2F1;p=platform%2Fupstream%2Fenlightenment.git e_view_smart : Add null checks Change-Id: I63fe6f7589041f43e67e0e3af94108818c44dedc Signed-off-by: jinbong.lee --- diff --git a/src/bin/core/e_view_smart.c b/src/bin/core/e_view_smart.c index 2aef126454..8fd1fbe544 100644 --- a/src/bin/core/e_view_smart.c +++ b/src/bin/core/e_view_smart.c @@ -61,7 +61,7 @@ _view_smart_cb_add(Evas_Object *eo) E_View_Smart *smart = (E_View_Smart *)evas_object_smart_data_get(eo); if (!smart) return; - if (smart->sc) smart->sc->add(smart); + if (smart->sc && smart->sc->add) smart->sc->add(smart); } static void @@ -70,7 +70,7 @@ _view_smart_cb_del(Evas_Object *eo) E_View_Smart *smart = (E_View_Smart *)evas_object_smart_data_get(eo); if (!smart) return; - if (smart->sc) smart->sc->del(smart); + if (smart->sc && smart->sc->del) smart->sc->del(smart); } static void @@ -79,7 +79,7 @@ _view_smart_cb_move(Evas_Object *eo, Evas_Coord x, Evas_Coord y) E_View_Smart *smart = (E_View_Smart *)evas_object_smart_data_get(eo); if (!smart) return; - if (smart->sc) smart->sc->move(smart, x, y); + if (smart->sc && smart->sc->move) smart->sc->move(smart, x, y); } static void @@ -88,7 +88,7 @@ _view_smart_cb_resize(Evas_Object *eo, Evas_Coord w, Evas_Coord h) E_View_Smart *smart = (E_View_Smart *)evas_object_smart_data_get(eo); if (!smart) return; - if (smart->sc) smart->sc->move(smart, w, h); + if (smart->sc && smart->sc->resize) smart->sc->resize(smart, w, h); } static void @@ -97,7 +97,7 @@ _view_smart_cb_show(Evas_Object *eo) E_View_Smart *smart = (E_View_Smart *)evas_object_smart_data_get(eo); if (!smart) return; - if (smart->sc) smart->sc->show(smart); + if (smart->sc && smart->sc->show) smart->sc->show(smart); } static void _view_smart_cb_hide(Evas_Object *eo) @@ -105,7 +105,7 @@ _view_smart_cb_hide(Evas_Object *eo) E_View_Smart *smart = (E_View_Smart *)evas_object_smart_data_get(eo); if (!smart) return; - if (smart->sc) smart->sc->hide(smart); + if (smart->sc && smart->sc->hide) smart->sc->hide(smart); } static void @@ -114,7 +114,7 @@ _view_smart_cb_color_set(Evas_Object *eo, int r, int g, int b, int a) E_View_Smart *smart = (E_View_Smart *)evas_object_smart_data_get(eo); if (!smart) return; - if (smart->sc) smart->sc->color_set(smart, r, g, b, a); + if (smart->sc && smart->sc->color_set) smart->sc->color_set(smart, r, g, b, a); } static void @@ -123,7 +123,7 @@ _view_smart_cb_clip_set(Evas_Object *eo, Evas_Object *clip) E_View_Smart *smart = (E_View_Smart *)evas_object_smart_data_get(eo); if (!smart) return; - if (smart->sc) smart->sc->clip_set(smart, evas_object_data_get(clip, "e_view")); + if (smart->sc && smart->sc->clip_set) smart->sc->clip_set(smart, evas_object_data_get(clip, "e_view")); } static void @@ -132,7 +132,7 @@ _view_smart_cb_clip_unset(Evas_Object *eo) E_View_Smart *smart = (E_View_Smart *)evas_object_smart_data_get(eo); if (!smart) return; - if (smart->sc) smart->sc->clip_unset(smart); + if (smart->sc && smart->sc->clip_unset) smart->sc->clip_unset(smart); } static void @@ -141,7 +141,7 @@ _view_smart_cb_calculate(Evas_Object *eo) E_View_Smart *smart = (E_View_Smart *)evas_object_smart_data_get(eo); if (!smart) return; - if (smart->sc) smart->sc->calculate(smart); + if (smart->sc && smart->sc->calculate) smart->sc->calculate(smart); } static void _view_smart_cb_member_add(Evas_Object *eo, Evas_Object *child) @@ -150,7 +150,7 @@ _view_smart_cb_member_add(Evas_Object *eo, Evas_Object *child) E_View *child_view = evas_object_data_get(child, "e_view"); if (!smart || !child_view) return; - if (smart->sc) smart->sc->member_add(smart, child_view); + if (smart->sc && smart->sc->member_add) smart->sc->member_add(smart, child_view); } static void @@ -160,7 +160,7 @@ _view_smart_cb_member_del(Evas_Object *eo, Evas_Object *child) E_View *child_view = evas_object_data_get(child, "e_view"); if (!smart || !child_view) return; - if (smart->sc) smart->sc->member_del(smart, child_view); + if (smart->sc && smart->sc->member_del) smart->sc->member_del(smart, child_view); } static void @@ -261,7 +261,7 @@ e_view_smart_create(E_View_Tree *parent, const E_View_Smart_Class *sc) E_API E_View * e_view_smart_view_get(E_View_Smart *smart) { - if (smart == NULL) return NULL; + if (!smart) return NULL; return &smart->view; } @@ -269,7 +269,7 @@ e_view_smart_view_get(E_View_Smart *smart) E_API E_View_Smart * e_view_smart_try_from_view(E_View *view) { - if (view == NULL) return NULL; + if (!view) return NULL; if (view->impl != &view_smart_impl) return NULL; @@ -280,7 +280,7 @@ e_view_smart_try_from_view(E_View *view) E_API void e_view_smart_size_set(E_View_Smart *smart, int width, int height) { - if (smart == NULL) return; + if (!smart) return; if (smart->width == width && smart->height == height) return; @@ -290,7 +290,7 @@ e_view_smart_size_set(E_View_Smart *smart, int width, int height) E_API void e_view_smart_size_get(E_View_Smart *smart, int *width, int *height) { - if (smart == NULL) return; + if (!smart) return; if (width) *width = smart->width; if (height) *height = smart->height; @@ -299,6 +299,8 @@ e_view_smart_size_get(E_View_Smart *smart, int *width, int *height) E_API void e_view_smart_resize_listener_add(E_View_Smart *smart, struct wl_listener *listener) { + if (!smart) return; + wl_signal_add(&smart->events.resize, listener); } @@ -321,11 +323,15 @@ e_view_smart_data_get(E_View_Smart *smart) E_API void e_view_smart_member_add(E_View_Smart *smart, E_View *member) { + if (!smart || !member) return; + evas_object_smart_member_add(member->eo, smart->view.eo); } E_API void e_view_smart_member_del(E_View *member) { + if (!member) return; + evas_object_smart_member_del(member->eo); }