From: SeokHoon Lee Date: Mon, 16 Oct 2017 06:36:08 +0000 (+0900) Subject: fix resource leak in error case X-Git-Tag: submit/tizen/20171017.080630^0 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=refs%2Fchanges%2F75%2F155775%2F2;p=platform%2Fcore%2Fapi%2Fscreen-mirroring.git fix resource leak in error case - In error get mount, it will occur to leak resource of server. Signed-off-by: SeokHoon Lee Change-Id: Ib1976595220df35e57595d7208c0f21f56a6bedf --- diff --git a/miracast_server/miracast_server_impl.c b/miracast_server/miracast_server_impl.c index 797496c..9c9db71 100644 --- a/miracast_server/miracast_server_impl.c +++ b/miracast_server/miracast_server_impl.c @@ -210,6 +210,7 @@ void __miracast_server_quit_program(MiracastServer *server) void *pool = NULL; int i; int ret = 0; + int serv_ref_cnt = 0; if (server->server == NULL) { scmirroring_error("server is already NULL"); @@ -226,7 +227,7 @@ void __miracast_server_quit_program(MiracastServer *server) g_object_unref(pool); } - int serv_ref_cnt = GST_OBJECT_REFCOUNT_VALUE(server->server); + serv_ref_cnt = GST_OBJECT_REFCOUNT_VALUE(server->server); scmirroring_debug("serv ref cnt:%d", serv_ref_cnt); for (i = 0; i < serv_ref_cnt; i++) @@ -627,6 +628,7 @@ int __miracast_server_start(MiracastServer *server_obj) mounts = gst_rtsp_server_get_mount_points(GST_RTSP_SERVER(server)); if (NULL == mounts) { scmirroring_error("Failed to get mount point..."); + g_object_unref(server); return SCMIRRORING_ERROR_INVALID_OPERATION; } diff --git a/packaging/capi-media-screen-mirroring.spec b/packaging/capi-media-screen-mirroring.spec index 8d7cfa0..87ff9e0 100644 --- a/packaging/capi-media-screen-mirroring.spec +++ b/packaging/capi-media-screen-mirroring.spec @@ -1,6 +1,6 @@ Name: capi-media-screen-mirroring Summary: A screen mirroring library in Tizen C API -Version: 0.1.87 +Version: 0.1.88 Release: 0 Group: Multimedia/API License: Apache-2.0