From: jaekuk, lee <juku1999@samsung.com>
Date: Thu, 15 Jun 2017 06:12:39 +0000 (+0900)
Subject: Changed a string to a variable
X-Git-Tag: accepted/tizen/3.0/common/20170630.142057~3
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=refs%2Fchanges%2F69%2F134169%2F2;p=platform%2Fframework%2Fweb%2Fcrosswalk-tizen.git

Changed a string to a variable

"fullscreen" => kViewmodeTypeFullscreen
"windowed"   => kViewmodeTypeWindowed

Change-Id: I354ce4c9fa84745c9c18d208faf570a9b16e970b
Signed-off-by: jaekuk, lee <juku1999@samsung.com>
---

diff --git a/runtime/browser/web_application.cc b/runtime/browser/web_application.cc
index 240df69..191023c 100755
--- a/runtime/browser/web_application.cc
+++ b/runtime/browser/web_application.cc
@@ -143,6 +143,9 @@ const char* kDefaultCSPRule =
 const char* kResWgtPath = "res/wgt/";
 const char* kAppControlMain = "http://tizen.org/appcontrol/operation/main";
 
+const std::string kViewmodeTypeFullscreen = "fullscreen";
+const std::string kViewmodeTypeWindowed = "windowed";
+
 // Looking for added privilege by Application developer in config.xml.
 bool FindPrivilegeFromConfig(common::ApplicationData* app_data,
                    const std::string& privilege) {
@@ -445,7 +448,7 @@ bool WebApplication::Initialize() {
   }
 
   if (app_data_->widget_info() != NULL &&
-        app_data_->widget_info()->view_modes() == "fullscreen") {
+        app_data_->widget_info()->view_modes() == kViewmodeTypeFullscreen) {
       window_->SetCurrentViewModeFullScreen(true);
       window_->FullScreen(true);
   }
@@ -969,7 +972,7 @@ void WebApplication::OnHardwareKey(WebView* view, const std::string& keyname) {
     if ((app_data_->setting_info() != NULL &&
          app_data_->setting_info()->backbutton_presence()) ||
         (app_data_->widget_info() != NULL &&
-         app_data_->widget_info()->view_modes() == "windowed")) {
+         app_data_->widget_info()->view_modes() == kViewmodeTypeWindowed)) {
       if (!view->Backward()) {
         if (view_stack_.size() == 1) {
           LOGGER(DEBUG) << "Terminate";
@@ -979,7 +982,7 @@ void WebApplication::OnHardwareKey(WebView* view, const std::string& keyname) {
         }
       }
 
-      if (app_data_->widget_info()->view_modes() == "fullscreen") {
+      if (app_data_->widget_info()->view_modes() == kViewmodeTypeFullscreen) {
         ewk_view_fullscreen_exit(view->evas_object());
         return;
       }