From: Jeongmo Yang Date: Fri, 5 Aug 2022 00:39:48 +0000 (+0900) Subject: Unmap memory after use X-Git-Tag: submit/tizen/20220817.064510^0 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=refs%2Fchanges%2F68%2F279268%2F4;p=platform%2Fcore%2Fapi%2Fmediacodec.git Unmap memory after use - The data pointer could be unavailable after gst_memory_unmap(). [Version] 0.6.24 [Issue Type] Improvement Change-Id: I2596aa01ab24da3893339ea34c959ccb699f83f3 Signed-off-by: Jeongmo Yang --- diff --git a/packaging/capi-media-codec.spec b/packaging/capi-media-codec.spec index 7802316..2ab1b78 100644 --- a/packaging/capi-media-codec.spec +++ b/packaging/capi-media-codec.spec @@ -4,8 +4,8 @@ Name: capi-media-codec Summary: A Media Codec library in Tizen Native API -Version: 0.6.23 -Release: 1 +Version: 0.6.24 +Release: 0 Group: Multimedia/API License: Apache-2.0 Source0: %{name}-%{version}.tar.gz diff --git a/src/media_codec_port_gst.c b/src/media_codec_port_gst.c index 68e9c5e..abad009 100644 --- a/src/media_codec_port_gst.c +++ b/src/media_codec_port_gst.c @@ -2516,7 +2516,6 @@ GstMCBuffer *__mc_gst_make_media_packet(mc_gst_core_t *core, GstBuffer *buffer) data = map.data; size = map.size; - gst_memory_unmap(mem, &map); } mcbuffer = g_new0(GstMCBuffer, 1); @@ -2526,6 +2525,10 @@ GstMCBuffer *__mc_gst_make_media_packet(mc_gst_core_t *core, GstBuffer *buffer) mcbuffer->buf_size = size; ret = __mc_fill_output_buffer(core, data, mcbuffer->buf_size, mcbuffer); + + if (!gst_is_tizen_memory(mem)) + gst_memory_unmap(mem, &map); + if (ret != MC_ERROR_NONE) { LOGW("failed to fill outbuf: %s (ox%08x)", _mc_error_to_string(ret), ret); g_free(mcbuffer);