From: Woochanlee Date: Thu, 25 Apr 2019 09:46:47 +0000 (+0900) Subject: edje_load: Delete unnecessary style update function call. X-Git-Tag: accepted/tizen/unified/20190429.103734~12 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=refs%2Fchanges%2F68%2F204668%2F2;p=platform%2Fupstream%2Fefl.git edje_load: Delete unnecessary style update function call. https://phab.enlightenment.org/D8560 I tried to push this commit on upstream. But We has diffrent logic for style update. @tizen_fix Change-Id: I1da315768cfe117029372717a86f0d5242c21d91 --- diff --git a/src/lib/edje/edje_load.c b/src/lib/edje/edje_load.c index c7a00f1..c5926b1 100644 --- a/src/lib/edje/edje_load.c +++ b/src/lib/edje/edje_load.c @@ -838,7 +838,17 @@ _edje_object_file_set_internal(Evas_Object *obj, const Eina_File *file, const ch *********************************************************************************** _edje_textblock_style_all_update(ed); */ - _edje_file_textblock_style_all_update(ed->file); + /* + The textblock styles are loaded at the same time when edje is loaded. + And if I change the color class or text class, it will update again. + + I think that if all the widgets are created and the theme is changed, + updating the whole style at this point is seen as a waste of resources. + + In case of custom theme, textbloack style is loaded when edje is loaded. + I don't think this is need here. + //_edje_file_textblock_style_all_update(ed->file); + */ /******* * END * *******/