From: Pawel Wasowski
Date: Wed, 6 Mar 2019 17:11:57 +0000 (+0100)
Subject: [messaging] Support new filtering options in findFolders (SMS/MMS)
X-Git-Tag: accepted/tizen/unified/20191122.122403~2^2
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=refs%2Fchanges%2F67%2F211867%2F3;p=platform%2Fcore%2Fapi%2Fwebapi-plugins.git
[messaging] Support new filtering options in findFolders (SMS/MMS)
Related ACR: TWDAPI-205
[Verification] tct-messaging-sms-tests & tct-messaging-mms-tests:
pass rate did not change after applying the commit
This commit has already been reviewed:
https://review.tizen.org/gerrit/#/c/platform/core/api/webapi-plugins/+/200975/
Change-Id of the original change was:
I8cea3b5cb0a0a19a827446c5bb34bce0e2710d7e
Change-Id: I88e7720dcbc6dd500d8bb27ae8aca4cd5d429655
Signed-off-by: Pawel Wasowski
---
diff --git a/src/messaging/message_folder.h b/src/messaging/message_folder.h
index a9a7ded..e88e54c 100644
--- a/src/messaging/message_folder.h
+++ b/src/messaging/message_folder.h
@@ -30,7 +30,7 @@ namespace extension {
namespace messaging {
enum MessageFolderType {
- MESSAGE_FOLDER_TYPE_INBOX,
+ MESSAGE_FOLDER_TYPE_INBOX = 1,
MESSAGE_FOLDER_TYPE_OUTBOX,
MESSAGE_FOLDER_TYPE_DRAFTS,
MESSAGE_FOLDER_TYPE_SENTBOX,
diff --git a/src/messaging/message_storage_short_msg.cc b/src/messaging/message_storage_short_msg.cc
index 2c1e472..c5bae61 100644
--- a/src/messaging/message_storage_short_msg.cc
+++ b/src/messaging/message_storage_short_msg.cc
@@ -225,24 +225,17 @@ void MessageStorageShortMsg::findFolders(FoldersCallbackData* callback) {
}
std::string content_type = getMsgServiceTypeString();
- std::string empty = "";
- std::shared_ptr folder;
-
- /* For SMS and MMS, folderId can be one of these values:
- *
- * INBOX = 1,
- * OUTBOX = 2,
- * DRAFTS = 3,
- * SENTBOX = 4
- */
-
- for (int i = 1; i < 5; i++) {
+ FolderPtr folder;
+
+ auto filter = callback->getFilter();
+ for (int i = MESSAGE_FOLDER_TYPE_INBOX; i < MESSAGE_FOLDER_TYPE_NOTSTANDARD; ++i) {
folder = std::make_shared(
- std::to_string(i), empty, std::to_string(m_id), content_type,
- MessagingUtil::messageFolderTypeToString((MessageFolderType)i), empty, (MessageFolderType)i,
+ std::to_string(i), "", std::to_string(m_id), content_type,
+ MessagingUtil::messageFolderTypeToString(static_cast(i)), "", static_cast(i),
false);
-
- callback->addFolder(folder);
+ if (filter->isMatching(folder.get())) {
+ callback->addFolder(folder);
+ }
}
guint id = g_idle_add(findFoldersCB, static_cast(callback));