From: Rusty Lynch Date: Wed, 11 Dec 2013 22:48:39 +0000 (-0800) Subject: Revert "Port "ecore-wayland: Improve opaque setting logic." patch from upstream" X-Git-Tag: accepted/tizen/20131212.180559^0 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=refs%2Fchanges%2F67%2F13667%2F1;p=platform%2Fupstream%2Fecore.git Revert "Port "ecore-wayland: Improve opaque setting logic." patch from upstream" This reverts commit 5e8b86bcba40af5ed822477f522346e293f437c3. On further testing using the latest stack to boot the default IVI image configuration it was discovered that this change causes an artifact in the homescreen. Until we know what causes this artifact then the change will be backed out. Note that if this orignal patch included a JIRA entry in the comment then it would be possible to understand what specific behavior in Tizen this is fixing (i.e. not a theoretical fix but something a user actually will hit) then we would also take that into account in deciding how much risk there is in reverting this change. Change-Id: Ib6c1d706840294a647525234e27ae9e3a05270bd --- diff --git a/src/lib/ecore_wayland/ecore_wl_window.c b/src/lib/ecore_wayland/ecore_wl_window.c index 682b402..16176b1 100644 --- a/src/lib/ecore_wayland/ecore_wl_window.c +++ b/src/lib/ecore_wayland/ecore_wl_window.c @@ -346,9 +346,6 @@ ecore_wl_window_buffer_attach(Ecore_Wl_Window *win, struct wl_buffer *buffer, in return; } - if (!win->surface) - return; - if (win->region.input) { wl_surface_set_input_region(win->surface, win->region.input); @@ -557,15 +554,6 @@ ecore_wl_window_update_size(Ecore_Wl_Window *win, int w, int h) if (!win) return; win->allocation.w = w; win->allocation.h = h; - - if ((!win->transparent) || (!win->alpha)) - { - if (win->region.opaque) wl_region_destroy(win->region.opaque); - win->region.opaque = - wl_compositor_create_region(_ecore_wl_disp->wl.compositor); - wl_region_add(win->region.opaque, win->allocation.x, win->allocation.y, - win->allocation.w, win->allocation.h); - } } EAPI void