From: Junghyun Yeon <jungh.yeon@samsung.com>
Date: Wed, 25 Jan 2017 07:12:22 +0000 (+0900)
Subject: Fix memory leak
X-Git-Tag: accepted/tizen/common/20170209.122508~2
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=refs%2Fchanges%2F67%2F111967%2F1;p=platform%2Fcore%2Fappfw%2Fslp-pkgmgr.git

Fix memory leak

Change-Id: I23853c597a9446e8e12d7f9ab211844be6d28ae2
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
---

diff --git a/client/src/pkgmgr.c b/client/src/pkgmgr.c
index 7246aba..a7d5d4f 100644
--- a/client/src/pkgmgr.c
+++ b/client/src/pkgmgr.c
@@ -396,7 +396,6 @@ API int pkgmgr_client_usr_install(pkgmgr_client *pc, const char *pkg_type,
 	GVariantBuilder *builder = NULL;
 	GVariant *args = NULL;
 	struct pkgmgr_client_t *client = (struct pkgmgr_client_t *)pc;
-	char *pkgtype = NULL;
 	struct cb_info *cb_info;
 
 	if (pc == NULL || pkg_path == NULL) {
@@ -419,9 +418,6 @@ API int pkgmgr_client_usr_install(pkgmgr_client *pc, const char *pkg_type,
 		return PKGMGR_R_EINVAL;
 	}
 
-	if (pkg_type)
-		pkgtype = strdup(pkg_type);
-
 	/* build arguments */
 	builder = g_variant_builder_new(G_VARIANT_TYPE("as"));
 	if (client->tep_path) {
@@ -439,7 +435,7 @@ API int pkgmgr_client_usr_install(pkgmgr_client *pc, const char *pkg_type,
 	g_variant_builder_unref(builder);
 
 	ret = pkgmgr_client_connection_send_request(client, "install",
-			g_variant_new("(uss@as)", uid, pkgtype ? pkgtype : "",
+			g_variant_new("(uss@as)", uid, pkg_type ? pkg_type : "",
 				pkg_path, args),
 			&result);
 	if (ret != PKGMGR_R_OK) {
@@ -555,7 +551,6 @@ API int pkgmgr_client_usr_mount_install(pkgmgr_client *pc, const char *pkg_type,
 	GVariantBuilder *builder = NULL;
 	GVariant *args = NULL;
 	struct pkgmgr_client_t *client = (struct pkgmgr_client_t *)pc;
-	char *pkgtype = NULL;
 	struct cb_info *cb_info;
 
 	if (pc == NULL || pkg_path == NULL) {
@@ -578,9 +573,6 @@ API int pkgmgr_client_usr_mount_install(pkgmgr_client *pc, const char *pkg_type,
 		return PKGMGR_R_EINVAL;
 	}
 
-	if (pkg_type)
-		pkgtype = strdup(pkg_type);
-
 	/* build arguments */
 	builder = g_variant_builder_new(G_VARIANT_TYPE("as"));
 	if (client->tep_path) {
@@ -596,7 +588,7 @@ API int pkgmgr_client_usr_mount_install(pkgmgr_client *pc, const char *pkg_type,
 	g_variant_builder_unref(builder);
 
 	ret = pkgmgr_client_connection_send_request(client, "mount_install",
-			g_variant_new("(uss@as)", uid, pkgtype ? pkgtype : "",
+			g_variant_new("(uss@as)", uid, pkg_type ? pkg_type : "",
 				pkg_path, args),
 			&result);
 	if (ret != PKGMGR_R_OK) {