From: SooChan Lim <sc1.lim@samsung.com>
Date: Thu, 20 Jul 2023 04:48:29 +0000 (+0900)
Subject: e_client: remove _e_calc_visibility variable
X-Git-Tag: accepted/tizen/unified/20230726.020650~3
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=refs%2Fchanges%2F66%2F296166%2F1;p=platform%2Fupstream%2Fenlightenment.git

e_client: remove _e_calc_visibility variable

Instead, use the e_comp_visibility_calculation_set/get function.

Change-Id: I9037aa595569efcc0ad2d56836f46350c0ae38cc
---

diff --git a/src/bin/e_client.c b/src/bin/e_client.c
index 6c4fe96..5603be5 100644
--- a/src/bin/e_client.c
+++ b/src/bin/e_client.c
@@ -64,8 +64,6 @@ static Eina_Rectangle action_orig = {0, 0, 0, 0};
 
 static E_Client_Resize_Object_Create_Cb _e_client_resize_object_create_cb = NULL;
 
-static Eina_Bool _e_calc_visibility = EINA_FALSE;
-
 static GMutex focused_ec_mutex;
 
 EINTERN void e_client_focused_set(E_Client *ec);
@@ -4106,10 +4104,13 @@ _e_client_cb_hook_shell_surface_ready(void *data EINA_UNUSED, E_Client *ec)
    _e_client_aux_hint_eval(ec);
 }
 
+// FIXME: This function has to be deleted and it remains for the backward compatibility.
+//        Please find and fix to use e_comp_visibility_calculation_set(EINA_TRUE)
+//        instead of e_client_visibility_calculate() call at e20 modules.
 E_API void
 e_client_visibility_calculate(void)
 {
-   _e_calc_visibility = EINA_TRUE;
+   e_comp_visibility_calculation_set(EINA_TRUE);
 }
 
 E_API void
@@ -4269,17 +4270,17 @@ e_client_idler_before(void)
 
         EINA_LIST_FOREACH(e_comp->zones, zl, zone)
           {
-             if (_e_calc_visibility)
+             if (e_comp_visibility_calculation_get())
                e_visibility_changed = _e_client_visibility_zone_calculate(zone);
              if (check_focus ||
                  (focused == NULL) ||
-                 (_e_calc_visibility && (defer_focus_stack != NULL)) ||
+                 (e_comp_visibility_calculation_get() && (defer_focus_stack != NULL)) ||
                  (e_visibility_changed))
                {
                   _e_client_focus_calculate(zone);
                }
           }
-        _e_calc_visibility = EINA_FALSE;
+        e_comp_visibility_calculation_set(EINA_FALSE);
      }
 
 
diff --git a/src/bin/e_client.h b/src/bin/e_client.h
index 07ad04d..b710c32 100644
--- a/src/bin/e_client.h
+++ b/src/bin/e_client.h
@@ -1191,7 +1191,7 @@ EINTERN Eina_Bool e_client_is_stacking(const E_Client *ec);
 EINTERN Eina_Bool e_client_desk_window_profile_available_check(E_Client *ec, const char *profile);
 EINTERN void      e_client_desk_window_profile_wait_desk_set(E_Client *ec, E_Desk *desk);
 EINTERN E_Client *e_client_transient_child_top_get(E_Client *ec, Eina_Bool consider_focus);
-E_API void      e_client_visibility_calculate(void);
+E_API void      e_client_visibility_calculate(void); // FIXME: This has to be deprecated.
 E_API void      e_client_visibility_skip_set(E_Client *ec, Eina_Bool skip);
 E_API void      e_client_post_raise_lower_set(E_Client *ec, Eina_Bool raise_set, Eina_Bool lower_set);
 E_API Eina_Bool e_client_first_mapped_get(E_Client *ec);