From: INSUN PYO Date: Fri, 13 Oct 2017 07:02:34 +0000 (+0000) Subject: Coverity fixes. X-Git-Tag: accepted/tizen/unified/20171019.145638~2 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=refs%2Fchanges%2F58%2F155458%2F1;p=platform%2Fcore%2Fsystem%2Ftlm.git Coverity fixes. Signed-off-by: INSUN PYO Change-Id: I25429182917b7911ec95a73f65f912e22091461c --- diff --git a/src/common/tlm-utils.c b/src/common/tlm-utils.c index fcd6a60..0bea3b6 100755 --- a/src/common/tlm-utils.c +++ b/src/common/tlm-utils.c @@ -68,7 +68,7 @@ tlm_user_get_name (uid_t user_id) if (size <= sizeof(struct passwd)) size = 1024; - for (; NULL != (tmp = g_realloc(buf, size)); size*=2) + for (; NULL != (tmp = realloc(buf, size)); size*=2) { buf = tmp; @@ -88,7 +88,7 @@ tlm_user_get_name (uid_t user_id) } if (buf) - g_free(buf); + free(buf); return pw_name; } @@ -105,7 +105,7 @@ tlm_user_get_uid (const gchar *username) if (size < sizeof(struct passwd)) size = 1024; - for (; NULL != (tmp = g_realloc(buf, size)); size*=2) + for (; NULL != (tmp = realloc(buf, size)); size*=2) { buf = tmp; @@ -121,7 +121,7 @@ tlm_user_get_uid (const gchar *username) } if (buf) - g_free(buf); + free(buf); return pw_uid; } @@ -138,7 +138,7 @@ tlm_user_get_gid (const gchar *username) if (size <= sizeof(struct passwd)) size = 1024; - for (; NULL != (tmp = g_realloc(buf, size)); size*=2) + for (; NULL != (tmp = realloc(buf, size)); size*=2) { buf = tmp; @@ -154,7 +154,7 @@ tlm_user_get_gid (const gchar *username) } if (buf) - g_free(buf); + free(buf); return pw_gid; } @@ -169,7 +169,7 @@ tlm_user_get_home_dir (const gchar *username) if (size <= sizeof(struct passwd)) size = 1024; - for (; NULL != (tmp = g_realloc(buf, size)); size*=2) + for (; NULL != (tmp = realloc(buf, size)); size*=2) { buf = tmp; @@ -189,7 +189,7 @@ tlm_user_get_home_dir (const gchar *username) } if (buf) - g_free(buf); + free(buf); return pw_dir; } @@ -204,7 +204,7 @@ tlm_user_get_shell (const gchar *username) if (size <= sizeof(struct passwd)) size = 1024; - for (; NULL != (tmp = g_realloc(buf, size)); size*=2) + for (; NULL != (tmp = realloc(buf, size)); size*=2) { buf = tmp; @@ -224,7 +224,7 @@ tlm_user_get_shell (const gchar *username) } if (buf) - g_free(buf); + free(buf); return pw_shell; } diff --git a/src/plugins/default/tlm-account-plugin-default.c b/src/plugins/default/tlm-account-plugin-default.c index 619340d..ce54b05 100755 --- a/src/plugins/default/tlm-account-plugin-default.c +++ b/src/plugins/default/tlm-account-plugin-default.c @@ -195,7 +195,7 @@ _cleanup_guest_user (TlmAccountPlugin *plugin, /* clear error */ errno = 0; - for (; NULL != (tmp = g_realloc(buf, size)); size*=2) + for (; NULL != (tmp = realloc(buf, size)); size*=2) { buf = tmp; @@ -209,7 +209,7 @@ _cleanup_guest_user (TlmAccountPlugin *plugin, user_name, strerror(errno)); if (buf) - g_free(buf); + free(buf); return FALSE; } @@ -218,7 +218,7 @@ _cleanup_guest_user (TlmAccountPlugin *plugin, DBG("No home folder entry found for user '%s'", user_name); if (buf) - g_free(buf); + free(buf); return FALSE; } @@ -226,7 +226,7 @@ _cleanup_guest_user (TlmAccountPlugin *plugin, res = delete_sub_files(pwd_entry->pw_dir); if (buf) - g_free(buf); + free(buf); return res; } @@ -248,7 +248,7 @@ _is_valid_user (TlmAccountPlugin *plugin, const gchar *user_name) /* clear error */ errno = 0; - for (; NULL != (tmp = g_realloc(buf, size)); size*=2) + for (; NULL != (tmp = realloc(buf, size)); size*=2) { buf = tmp; @@ -263,12 +263,12 @@ _is_valid_user (TlmAccountPlugin *plugin, const gchar *user_name) DBG("Could not get info for user '%s', error : %s", user_name, strerr_buf); if (buf) - g_free(buf); + free(buf); return FALSE; } if (buf) - g_free(buf); + free(buf); return TRUE; }