From: dyamy-lee <dyamy.lee@samsung.com>
Date: Tue, 12 Mar 2024 11:20:29 +0000 (+0900)
Subject: revert xmlDocSetRootElement() location
X-Git-Tag: accepted/tizen/unified/20240315.111155~1^2
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=refs%2Fchanges%2F57%2F307857%2F1;p=platform%2Fcore%2Fuifw%2Fvoice-control.git

revert xmlDocSetRootElement() location

Inside xmlDocSetRootElement(), it checked root is null.
If root is null, it doesn't connect it's memory. So, it needs not null of root.
Then, this patch rollback to previous logic.

Change-Id: Ia291aec3a55b5d53e211de6d181df31e02cc8855
---

diff --git a/engine-parser/src/vc-engine-parser.c b/engine-parser/src/vc-engine-parser.c
index 9ccc88d..44d0f8e 100644
--- a/engine-parser/src/vc-engine-parser.c
+++ b/engine-parser/src/vc-engine-parser.c
@@ -353,8 +353,6 @@ static int __write_metadata_inxml(const char *pkgid, const char *appid, GList *l
 	xmlNodePtr root = NULL;
 	xmlNodePtr cur = NULL;
 
-	xmlDocSetRootElement(g_doc, root);
-
 	root = xmlNewNode(NULL, (const xmlChar*)VC_TAG_ENGINE_BASE);
 
 	if (NULL == root) {
@@ -362,6 +360,7 @@ static int __write_metadata_inxml(const char *pkgid, const char *appid, GList *l
 //		xmlFreeDoc(g_doc);
 		return -1;
 	}
+	xmlDocSetRootElement(g_doc, root);
 
 	iter = g_list_first(list);
 	while (NULL != iter) {