From: Szymon Jastrzebski <s.jastrzebsk@partner.samsung.com>
Date: Tue, 7 Nov 2017 10:44:27 +0000 (+0100)
Subject: [Exif] Fixing  warning: control reaches end of non-void function
X-Git-Tag: submit/tizen_4.0/20171108.104235~2^2
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=refs%2Fchanges%2F42%2F159042%2F3;p=platform%2Fcore%2Fapi%2Fwebapi-plugins.git

[Exif] Fixing  warning: control reaches end of non-void function

[Verification] Code compiles

Change-Id: I8d89d09dc864bfa4b43f2aec78327a38a0960c81
Signed-off-by: Szymon Jastrzebski <s.jastrzebsk@partner.samsung.com>
---

diff --git a/src/exif/get_exif_info.cc b/src/exif/get_exif_info.cc
index e80f8f09..a5e4e81c 100644
--- a/src/exif/get_exif_info.cc
+++ b/src/exif/get_exif_info.cc
@@ -42,9 +42,8 @@ Rational GetRationalFromEntry(ExifEntry* entry, ExifData* exif_data) {
   if (EXIF_FORMAT_RATIONAL == entry->format && entry->components >= 1 && entry->data) {
     const ExifByteOrder order = exif_data_get_byte_order(exif_data);
     return Rational(exif_get_rational(entry->data, order));
-  } else {
-    return Rational::createInvalid();
   }
+  return Rational::createInvalid();
 }
 
 bool GetRationalsFromEntry(ExifEntry* entry, ExifData* exif_data, unsigned long required_count,
@@ -60,9 +59,8 @@ bool GetRationalsFromEntry(ExifEntry* entry, ExifData* exif_data, unsigned long
     }
 
     return true;
-  } else {
-    return false;
   }
+  return false;
 }
 
 bool GetGCSPositionFromEntry(ExifEntry* entry, ExifData* exif_data, GCSPosition& out_pos) {
@@ -75,9 +73,8 @@ bool GetGCSPositionFromEntry(ExifEntry* entry, ExifData* exif_data, GCSPosition&
     out_pos.seconds =
         Rational(exif_get_rational(entry->data + 2 * ExifTypeInfo::RationalSize, order));
     return true;
-  } else {
-    return false;
   }
+  return false;
 }
 
 bool DecomposeExifUndefined(ExifEntry* entry, std::string& type, std::string& value) {