From: Damian Pietruchowski <d.pietruchow@samsung.com>
Date: Thu, 16 Mar 2017 10:45:19 +0000 (+0100)
Subject: Add removing xml for installation rollback
X-Git-Tag: submit/tizen/20170407.042402~3
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=refs%2Fchanges%2F42%2F119342%2F2;p=platform%2Fcore%2Fappfw%2Ftpk-backend.git

Add removing xml for installation rollback

For installation request, backup_path_ do not exist
in StepConvertXml, but xml file should be removed
in rollback.

Change-Id: I984b9a44af0e0e6c4f51b0769f0f877a197b99ed
Signed-off-by: Damian Pietruchowski <d.pietruchow@samsung.com>
---

diff --git a/src/tpk/step/pkgmgr/step_convert_xml.cc b/src/tpk/step/pkgmgr/step_convert_xml.cc
index 03f6a4f..f7877e6 100644
--- a/src/tpk/step/pkgmgr/step_convert_xml.cc
+++ b/src/tpk/step/pkgmgr/step_convert_xml.cc
@@ -140,8 +140,8 @@ common_installer::Step::Status StepConvertXml::clean() {
 }
 
 common_installer::Step::Status StepConvertXml::undo() {
-  if (!backup_path_.empty()) {
-    if (ci::Remove(new_path_)) {
+  if (ci::Remove(new_path_)) {
+    if (!backup_path_.empty()) {
       bs::error_code error;
       bf::rename(backup_path_, new_path_, error);
       if (error)