From: Eunhye Choi <eunhae1.choi@samsung.com>
Date: Mon, 8 Apr 2024 02:31:57 +0000 (+0900)
Subject: [0.6.292] Remove unused reference to fix mem leak
X-Git-Tag: accepted/tizen/8.0/unified/20240409.150651^0
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=refs%2Fchanges%2F41%2F309241%2F1;p=platform%2Fcore%2Fmultimedia%2Flibmm-player.git

[0.6.292] Remove unused reference to fix mem leak

Change-Id: I78b27f070340eda640b23d5552f2a83a897eb68e
---

diff --git a/packaging/libmm-player.spec b/packaging/libmm-player.spec
index c29c45b..45873ee 100644
--- a/packaging/libmm-player.spec
+++ b/packaging/libmm-player.spec
@@ -1,6 +1,6 @@
 Name:       libmm-player
 Summary:    Multimedia Framework Player Library
-Version:    0.6.291
+Version:    0.6.292
 Release:    0
 Group:      Multimedia/Libraries
 License:    Apache-2.0
diff --git a/src/include/mm_player_priv.h b/src/include/mm_player_priv.h
index 1861ffc..c5fbb44 100644
--- a/src/include/mm_player_priv.h
+++ b/src/include/mm_player_priv.h
@@ -764,10 +764,6 @@ typedef struct {
 	GCond subtitle_info_cond;
 	GMutex subtitle_info_mutex;
 
-	/* stream collection */
-	GstStreamCollection *collection;
-	guint stream_notify_id;
-
 	mmplayer_track_t track[MM_PLAYER_TRACK_TYPE_MAX];
 
 	guint internal_text_idx;
diff --git a/src/mm_player_gst.c b/src/mm_player_gst.c
index b99a7fc..858d916 100644
--- a/src/mm_player_gst.c
+++ b/src/mm_player_gst.c
@@ -1929,30 +1929,6 @@ __mmplayer_dump_collection(GstStreamCollection * collection)
 	}
 }
 
-static void
-__mmplayer_stream_notify_cb(GstStreamCollection *collection,
-			GstStream *stream, GParamSpec *pspec, gpointer data)
-{
-	LOGD ("Got stream-notify from stream %s for %s (collection %p)\n",
-				gst_stream_get_stream_id(stream), pspec->name, collection);
-	if (g_str_equal(pspec->name, "caps")) {
-		GstCaps *caps = gst_stream_get_caps(stream);
-		MMPLAYER_LOG_GST_CAPS_TYPE(caps);
-		gst_caps_unref(caps);
-	}
-
-#ifdef __DEBUG__
-	if (g_str_equal (pspec->name, "tags")) {
-		GstTagList *tags = gst_stream_get_tags(stream);
-		if (tags) {
-			LOGD ("  tags:\n");
-			gst_tag_list_foreach(tags, __mmplayer_print_tag_foreach, GUINT_TO_POINTER(MMPLAYER_TAG_INDENT));
-			gst_tag_list_unref(tags);
-		}
-	}
-#endif
-}
-
 static void
 __mmplayer_gst_bus_msg_callback(GstMessage *msg, gpointer data)
 {
@@ -2065,15 +2041,6 @@ __mmplayer_gst_bus_msg_callback(GstMessage *msg, gpointer data)
 		gst_message_parse_stream_collection(msg, &collection);
 		if (collection) {
 			__mmplayer_dump_collection(collection);
-			if (player->collection && player->stream_notify_id) {
-				g_signal_handler_disconnect(player->collection, player->stream_notify_id);
-				player->stream_notify_id = 0;
-			}
-			gst_object_replace((GstObject **)&player->collection, (GstObject *)collection);
-			if (player->collection) {
-				player->stream_notify_id = g_signal_connect(player->collection, "stream-notify",
-							(GCallback)__mmplayer_stream_notify_cb, player);
-			}
 			gst_object_unref(collection);
 		}
 	} break;
@@ -2094,7 +2061,7 @@ __mmplayer_gst_bus_msg_callback(GstMessage *msg, gpointer data)
 					gst_object_unref(stream);
 					break;
 				}
-				LOGD ("  Stream #%d : %s\n", i, gst_stream_get_stream_id(stream));
+				LOGD("  Stream #%d : %s\n", i, gst_stream_get_stream_id(stream));
 				if (player->track[type].active_track_index == INVALID_TRACK_INDEX) {
 					int stream_index = INVALID_TRACK_INDEX;
 					if (_mmplayer_get_track_index(player, type, stream, &stream_index) == MM_ERROR_NONE) {
diff --git a/src/mm_player_priv.c b/src/mm_player_priv.c
index ec68a82..6f8f70c 100644
--- a/src/mm_player_priv.c
+++ b/src/mm_player_priv.c
@@ -1297,11 +1297,11 @@ __mmplayer_gst_make_selector(mmplayer_t *player, main_element_id_e elem_idx, mmp
 		LOGE("failed to add selector to pipeline");
 
 		if (player->track[stream_type].block_id != 0)
-		  gst_pad_remove_probe (srcpad, player->track[stream_type].block_id);
+		  gst_pad_remove_probe(srcpad, player->track[stream_type].block_id);
 		player->track[stream_type].block_id = 0;
 
 		if (player->track[stream_type].event_probe_id != 0)
-		  gst_pad_remove_probe (srcpad, player->track[stream_type].event_probe_id);
+		  gst_pad_remove_probe(srcpad, player->track[stream_type].event_probe_id);
 		player->track[stream_type].event_probe_id = 0;
 
 		gst_object_unref(GST_OBJECT(srcpad));