From: Jaechul Lee <jcsing.lee@samsung.com>
Date: Mon, 19 Jun 2023 07:43:37 +0000 (+0900)
Subject: Fix coverity issue(UNUSED_VALUE)
X-Git-Tag: accepted/tizen/unified/20230621.023255~1
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=refs%2Fchanges%2F32%2F294432%2F2;p=platform%2Fcore%2Fmultimedia%2Fpulseaudio-modules-tizen.git

Fix coverity issue(UNUSED_VALUE)

[Version] 15.0.43
[Issue Type] Coverity(1677535)

Change-Id: I9b8e6c67e9a2fc96da95b31b8e8c21a84d2a2d96
Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>
---

diff --git a/packaging/pulseaudio-modules-tizen.spec b/packaging/pulseaudio-modules-tizen.spec
index ba66270..25e4812 100644
--- a/packaging/pulseaudio-modules-tizen.spec
+++ b/packaging/pulseaudio-modules-tizen.spec
@@ -2,7 +2,7 @@
 
 Name:             pulseaudio-modules-tizen
 Summary:          Pulseaudio modules for Tizen
-Version:          15.0.42
+Version:          15.0.43
 Release:          0
 Group:            Multimedia/Audio
 License:          LGPL-2.1+
diff --git a/src/module-tizenaudio-sink.c b/src/module-tizenaudio-sink.c
index 187ebf1..46cb580 100644
--- a/src/module-tizenaudio-sink.c
+++ b/src/module-tizenaudio-sink.c
@@ -422,7 +422,6 @@ static int process_render(struct userdata *u, pa_usec_t now) {
 
 static void thread_func(void *userdata) {
     struct userdata *u = userdata;
-    unsigned short revents = 0;
 
     pa_assert(u);
 
@@ -481,7 +480,10 @@ static void thread_func(void *userdata) {
 
         if (PA_SINK_IS_OPENED(u->sink->thread_info.state)) {
             struct pollfd *pollfd;
+
             if (u->rtpoll_item) {
+                unsigned short revents = 0;
+
                 pollfd = pa_rtpoll_item_get_pollfd(u->rtpoll_item, NULL);
                 revents = pollfd->revents;
                 if (revents & ~POLLOUT) {
@@ -491,9 +493,6 @@ static void thread_func(void *userdata) {
 
                     /* Need to reset revents because pa_rtpoll_run just returns without calling poll */
                     pollfd->revents = 0;
-                    revents = 0;
-                } else {
-                    //pa_log_debug("Poll wakeup.", revents);
                 }
             }
         }
diff --git a/src/module-tizenaudio-source.c b/src/module-tizenaudio-source.c
index 618c803..cc596d3 100644
--- a/src/module-tizenaudio-source.c
+++ b/src/module-tizenaudio-source.c
@@ -345,7 +345,6 @@ static int process_render(struct userdata *u, pa_usec_t now) {
 
 static void thread_func(void *userdata) {
     struct userdata *u = userdata;
-    unsigned short revents = 0;
 
     pa_assert(u);
     pa_log_debug("Thread starting up");
@@ -400,16 +399,16 @@ static void thread_func(void *userdata) {
 
         if (PA_SOURCE_IS_OPENED(u->source->thread_info.state)) {
             struct pollfd *pollfd;
+
             if (u->rtpoll_item) {
+                unsigned short revents = 0;
+
                 pollfd = pa_rtpoll_item_get_pollfd(u->rtpoll_item, NULL);
                 revents = pollfd->revents;
                 if (revents & ~POLLIN) {
                     pa_log_debug("Poll error 0x%x occured, try recover.", revents);
                     pa_hal_interface_pcm_recover(u->hal_interface, u->pcm_handle, revents);
                     u->first = true;
-                    revents = 0;
-                } else {
-                    //pa_log_debug("Poll wakeup.", revents);
                 }
             }
         }