From: Hwankyu Jhun <h.jhun@samsung.com>
Date: Fri, 3 Mar 2023 04:49:55 +0000 (+0000)
Subject: Delete unused files after process shutdown
X-Git-Tag: accepted/tizen/unified/20230309.035153~5
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=refs%2Fchanges%2F32%2F289232%2F4;p=platform%2Fcore%2Fappfw%2Flaunchpad.git

Delete unused files after process shutdown

After the process is terminated, the launchpad deletes unnecessary files.
To debug & profile dotnet applications, the coreclr creates "clr-debug-pipe-"
and "dotnet-diagnostic-" files. The launchpad deletes the files if the files
exists. To avoid blocking the main thread of the launchpad, this patch
creates a new worker thread that is "RecycleBin+".

Change-Id: I68e02359ed2ec79801b46da2f45ef54b5c35f4b9
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
---

diff --git a/src/launchpad-process-pool/launchpad_signal.cc b/src/launchpad-process-pool/launchpad_signal.cc
index be233a0..0082b84 100644
--- a/src/launchpad-process-pool/launchpad_signal.cc
+++ b/src/launchpad-process-pool/launchpad_signal.cc
@@ -26,24 +26,34 @@
 #include <sys/wait.h>
 #include <unistd.h>
 
+#include <string>
+#include <vector>
+
 #include "launchpad-process-pool/launchpad_dbus.h"
 #include "launchpad-process-pool/launchpad_io_channel.h"
+#include "launchpad-process-pool/launchpad_worker.h"
 #include "lib/common/inc/launchpad_common.h"
 #include "lib/common/inc/launchpad_proc.h"
 #include "lib/common/inc/launchpad_socket.h"
 #include "lib/common/inc/log_private.h"
 
-#define HYDRA_SIGCHLD_SOCK ".hydra-sigchld-sock"
+namespace {
+
+constexpr const char HYDRA_SIGCHLD_SOCK[] = ".hydra-sigchld-sock";
+
+pid_t __pid;
+sigset_t __mask;
+sigset_t __old_mask;
+socket_h __sigchld_socket;
+io_channel_h __sigchld_channel;
+socket_h __hydra_sigchld_socket;
+io_channel_h __hydra_sigchld_channel;
+signal_sigchld_cb __callback;
+void* __user_data;
+
+worker_h recycle_bin;
 
-static pid_t __pid;
-static sigset_t __mask;
-static sigset_t __old_mask;
-static socket_h __sigchld_socket;
-static io_channel_h __sigchld_channel;
-static socket_h __hydra_sigchld_socket;
-static io_channel_h __hydra_sigchld_channel;
-static signal_sigchld_cb __callback;
-static void* __user_data;
+}  // namespace
 
 static gboolean __hydra_sigchld_recovery_cb(gpointer data);
 static gboolean __sigchld_recovery_cb(gpointer data);
@@ -69,10 +79,51 @@ static void __socket_garbage_collector(void) {
   closedir(dp);
 }
 
-static void __sigchld_action(int pid) {
-  _dbus_send_app_dead_signal(pid);
+static void __delete_unused_files(pid_t pid) {
+  std::vector<std::string> files = {
+    "clr-debug-pipe-" + std::to_string(pid) + "-",
+    "dotnet-diagnostic-" + std::to_string(pid) + "-"
+  };
+
+  DIR* dp = opendir("/tmp");
+  if (dp == nullptr) {
+    _E("opendir() is failed");
+    return;
+  }
+
+  struct dirent* dentry = nullptr;
+  while ((dentry = readdir(dp)) != nullptr) {
+    if (dentry->d_name[0] == '.')
+      continue;
+
+    if (dentry->d_name[0] != 'c' && dentry->d_name[0] != 'd')
+      continue;
+
+    for (size_t i = 0; i < files.size(); ++i) {
+      if (files[i].compare(0, files[i].length(), dentry->d_name, 0,
+              files[i].length()) == 0) {
+        std::string path = std::string("/tmp/") + dentry->d_name;
+        unlink(path.c_str());
+        _W("unlink(%s)", path.c_str());
+      }
+    }
+  }
+  closedir(dp);
+}
+
+static bool __garbage_collector(void *user_data) {
+  pid_t pid = GPOINTER_TO_INT(
+      reinterpret_cast<unsigned long>(user_data) & UINT32_MAX);
+  _W("pid(%d)", pid);
   _delete_sock_path(pid, getuid());
+  __delete_unused_files(pid);
   __socket_garbage_collector();
+  return false;
+}
+
+static void __sigchld_action(int pid) {
+  _dbus_send_app_dead_signal(pid);
+  _worker_add_job(recycle_bin, __garbage_collector, GINT_TO_POINTER(pid));
 }
 
 static int __check_permission(int pid) {
@@ -377,6 +428,12 @@ int _signal_init(void) {
     }
   }
 
+  ret = _worker_create("RecycleBin+", &recycle_bin);
+  if (ret < 0) {
+    _E("_worker_create() is failed");
+    return ret;
+  }
+
   return 0;
 }
 
@@ -389,6 +446,9 @@ void _signal_fini(void) {
 #endif
 
   _D("SIGNAL_FINI");
+  if (getpid() == __pid)
+    _worker_destroy(recycle_bin);
+
   _signal_set_sigchld_cb(nullptr, nullptr);
   __hydra_sigchld_fini();
   __sigchld_fini();