From: Sinjae Lee <sinjae4b.lee@samsung.com>
Date: Sat, 21 Jun 2014 12:21:29 +0000 (+0900)
Subject: (Indicator) Skip updating when indicator is not showing
X-Git-Tag: dali_1.0.0~20
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=refs%2Fchanges%2F31%2F24131%2F1;p=platform%2Fcore%2Fuifw%2Fdali-adaptor.git

(Indicator) Skip updating when indicator is not showing

[problem] Dali render once by indicator updating even indicator is not showing
[cause] Calls RequestUpdateOnce() for every indicator update signal
[solution] Check mIsShowing before updating

Change-Id: Ie03395aba8baf1764189f5d5f8df4ff2624ea199
Signed-off-by: Adeel Kazmi <adeel.kazmi@samsung.com>
---

diff --git a/adaptors/tizen/internal/common/indicator-impl.cpp b/adaptors/tizen/internal/common/indicator-impl.cpp
index e5400ad..8a481a1 100644
--- a/adaptors/tizen/internal/common/indicator-impl.cpp
+++ b/adaptors/tizen/internal/common/indicator-impl.cpp
@@ -907,11 +907,15 @@ void Indicator::UpdateImageData()
   {
     if(mPixmap == 0)
     {
+      // in case of shm indicator (not pixmap), not sure we can skip it when mIsShowing is false
       CopyToBuffer();
     }
     else
     {
-      mAdaptor->RequestUpdateOnce();
+      if(mIsShowing)
+      {
+        mAdaptor->RequestUpdateOnce();
+      }
     }
   }
 }
@@ -1053,7 +1057,7 @@ void Indicator::DataReceived( void* event )
   {
     case OP_UPDATE:
       DALI_LOG_INFO( gIndicatorLogFilter, Debug::General, "Indicator client received: OP_UPDATE\n" );
-      if(mPixmap != 0)
+      if(mPixmap != 0 && mIsShowing)
       {
         mAdaptor->RequestUpdateOnce();
       }