From: Denis Dolzhenko Date: Fri, 23 Sep 2016 11:45:31 +0000 (+0300) Subject: TizenRefApp-7250 Back button doesn't close Conversation view X-Git-Tag: submit/tizen/20160926.072415^2~2 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=refs%2Fchanges%2F28%2F89428%2F1;p=profile%2Fmobile%2Fapps%2Fnative%2Fmessage.git TizenRefApp-7250 Back button doesn't close Conversation view Change-Id: Iea750762a2408e67239843a333add9df4cce4077 Signed-off-by: Denis Dolzhenko --- diff --git a/src/Common/Controller/src/NaviFrameController.cpp b/src/Common/Controller/src/NaviFrameController.cpp index 01f7388f..f5e774e8 100644 --- a/src/Common/Controller/src/NaviFrameController.cpp +++ b/src/Common/Controller/src/NaviFrameController.cpp @@ -103,7 +103,11 @@ void NaviFrameController::execCmd(const AppControlComposeRef &cmd) if(prepare(*cmd)) { Conversation *conv = getTopFrame(); - if(!conv) + if(conv) + { + promote(*conv); + } + else { conv = new Conversation(*this); push(*conv); diff --git a/src/Common/View/src/NaviFrameView.cpp b/src/Common/View/src/NaviFrameView.cpp index 5e600ae2..cd1fb04a 100644 --- a/src/Common/View/src/NaviFrameView.cpp +++ b/src/Common/View/src/NaviFrameView.cpp @@ -182,7 +182,7 @@ void NaviFrameView::insertToBottom(NaviFrameItem &item) void NaviFrameView::promote(NaviFrameItem &item) { - bool isTop = &item != getTopFrame(); + bool isTop = &item == getTopFrame(); if(!isTop) { m_TransitionStatus = true; diff --git a/src/Conversation/Body/View/src/BodyView.cpp b/src/Conversation/Body/View/src/BodyView.cpp index 4cd92215..421c107f 100644 --- a/src/Conversation/Body/View/src/BodyView.cpp +++ b/src/Conversation/Body/View/src/BodyView.cpp @@ -77,6 +77,10 @@ void BodyView::setText(const std::string &text) free(markupText); } } + else + { + clear(); + } } void BodyView::setFocus(bool focus) diff --git a/src/Conversation/Main/Controller/src/Conversation.cpp b/src/Conversation/Main/Controller/src/Conversation.cpp index 74a366bd..32b3f860 100644 --- a/src/Conversation/Main/Controller/src/Conversation.cpp +++ b/src/Conversation/Main/Controller/src/Conversation.cpp @@ -1264,11 +1264,12 @@ void Conversation::onNoRecipDiscardButtonClicked(Popup &popup, int buttonId) { if(isDefferedCmd()) { + m_pBody->clear(); if(m_DefferedCmd.defaultCmd) { // If we came from notification menu and unread threads will be more than one, we should to go back on thread list view if(m_DefferedCmd.defaultCmd->getDefaultType() == AppControlDefault::NotificationType && getMsgEngine().getStorage().getUnreadThreadCount() > 1) { - pop(); + pop(); } else { // Go to needed conversation