From: Kyungwook Tak <k.tak@samsung.com>
Date: Tue, 19 Jul 2016 07:21:51 +0000 (+0900)
Subject: Fix memory leak on decrypt migrated wgt
X-Git-Tag: accepted/tizen/common/20160721.175841~1
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=refs%2Fchanges%2F25%2F80625%2F2;p=platform%2Fcore%2Fsecurity%2Flibwebappenc.git

Fix memory leak on decrypt migrated wgt

Change-Id: I300a887e7e633af858e102797c500d1266566355
Signed-off-by: Kyungwook Tak <k.tak@samsung.com>
---

diff --git a/srcs/web_app_enc.c b/srcs/web_app_enc.c
index a5224ea..083addf 100644
--- a/srcs/web_app_enc.c
+++ b/srcs/web_app_enc.c
@@ -76,10 +76,7 @@ int _wae_decrypt_downloaded_web_application(const char *pkg_id, wae_app_type_e a
 				  "needed secure-storage data migration.", pkg_id);
 
 		ret = decrypt_by_old_ss_algo(pkg_id, data, data_len, pdecrypted_data, pdecrypted_data_len);
-		if (ret != WAE_ERROR_NONE)
-			goto error;
-		else
-			return WAE_ERROR_NONE;
+		goto error; // always go to error to skip decyprt_aes_cbc
 	} else if (ret != WAE_ERROR_NONE) {
 		goto error;
 	}