From: Myoungwoon Roy, Kim <myoungwoon.kim@samsung.com>
Date: Wed, 7 Feb 2018 04:50:24 +0000 (+0900)
Subject: ecore_event: Fix a break of consistency of return data
X-Git-Tag: submit/sandbox/upgrade/efl120/20180319.053334~40
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=refs%2Fchanges%2F21%2F169521%2F1;p=platform%2Fupstream%2Fefl.git

ecore_event: Fix a break of consistency of return data

Summary:
This patch fixes a break of consistency of return data from ecore_event_del.
Before EFL 1.20, when calling ecore_event_add(ECORE_EVENT_SIGNAL_USER, event_data, NULL, &data);
The user data(data) is saved at event->data. and when user calls ecore_event_del(event_handler),
ecore_event_del returns event->data. However, current ecore_event_del returns pd->ev.
I think it is ABI break.

Test Plan: Execute test suite

Reviewers: cedric, raster, stefan_schmidt, Jaehyun_Cho

Reviewed By: Jaehyun_Cho

Differential Revision: https://phab.enlightenment.org/D5786

Change-Id: Id0ff5dc61cbb18b0ffae378dd7490d4b75e0ed9f
---

diff --git a/src/lib/ecore/ecore_events.c b/src/lib/ecore/ecore_events.c
index 7070452..3f9e160 100644
--- a/src/lib/ecore/ecore_events.c
+++ b/src/lib/ecore/ecore_events.c
@@ -80,7 +80,7 @@ ecore_event_del(Ecore_Event *event)
 {
    void *data = NULL;
    if (!event) return data;
-   ecore_event_message_data_get((Eo *)event, NULL, &data, NULL, NULL);
+   ecore_event_message_data_get((Eo *)event, NULL, NULL, NULL, &data);
    _efl_loop_message_unsend((Eo *)event);
    return data;
 }