From: Paul Wisbey <p.wisbey@samsung.com>
Date: Fri, 19 Sep 2014 10:51:51 +0000 (+0100)
Subject: Guard against invalid PanGesture timestamps
X-Git-Tag: accepted/tizen/common/20140925.172112~10^2
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=refs%2Fchanges%2F19%2F27819%2F1;p=platform%2Fcore%2Fuifw%2Fdali-core.git

Guard against invalid PanGesture timestamps

[problem]     Pan prediction code is not robust enough.
[cause]       Assumptions made about PanGesture timestamps e.g. that current
              VSync time is older than queued PanGesture times.
[solution]    Added more guard logic.

Change-Id: I917fbf3c20367a071e122bb2565971725a5cafc3
---

diff --git a/dali/internal/update/gestures/scene-graph-pan-gesture.cpp b/dali/internal/update/gestures/scene-graph-pan-gesture.cpp
index ccf2b8d..8a070c6 100644
--- a/dali/internal/update/gestures/scene-graph-pan-gesture.cpp
+++ b/dali/internal/update/gestures/scene-graph-pan-gesture.cpp
@@ -107,7 +107,17 @@ void PanGesture::PredictiveAlgorithm1(int eventsThisFrame, PanInfo& gestureOut,
   bool previousVelocity = false;
   float previousAccel = 0.0f;
   unsigned int lastTime(0);
-  unsigned int interpolationTime = (lastVSyncTime + mPredictionAmount) - gestureOut.time;
+
+  unsigned int interpolationTime = lastVSyncTime + mPredictionAmount;
+  if( interpolationTime > gestureOut.time ) // Guard against the rare case when gestureOut.time > (lastVSyncTime + mPredictionAmount)
+  {
+    interpolationTime -= gestureOut.time;
+  }
+  else
+  {
+    interpolationTime = 0u;
+  }
+
   while( iter != endIter )
   {
     PanInfo currentGesture = *iter;
@@ -124,13 +134,19 @@ void PanGesture::PredictiveAlgorithm1(int eventsThisFrame, PanInfo& gestureOut,
     float velMag = currentGesture.screen.velocity.Length();
     float velDiff = velMag - screenVelocity.Length();
     float acceleration = 0.0f;
-    float time = (float)(currentGesture.time - lastTime);
+
+    float time(0.f);
+    if (currentGesture.time > lastTime) // Guard against invalid timestamps
+    {
+      time = static_cast<float>( currentGesture.time - lastTime );
+    }
     if( time > Math::MACHINE_EPSILON_1 )
     {
       acceleration = velDiff / time;
     }
+
     float newVelMag = 0.0f;
-    int currentInterpolation = interpolationTime; //(lastVSyncTime + mPredictionAmount) - currentGesture.time;
+    int currentInterpolation = interpolationTime;
     if( !havePreviousAcceleration )
     {
       newVelMag =  velMag;