From: jh9216.park <jh9216.park@samsung.com>
Date: Mon, 1 Feb 2021 00:24:13 +0000 (-0500)
Subject: Add virtual destructor
X-Git-Tag: accepted/tizen/unified/20210202.143614~1
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=refs%2Fchanges%2F19%2F252619%2F1;p=platform%2Fcore%2Fappfw%2Fapp-installers.git

Add virtual destructor

- require : https://review.tizen.org/gerrit/#/c/platform/core/appfw/manifest-parser/+/252618/

Change-Id: I1d7eaed8371bb7c456f37f276f06194f50f3fad4
Signed-off-by: jh9216.park <jh9216.park@samsung.com>
---

diff --git a/CMakeLists.txt b/CMakeLists.txt
index 8f5a18e..011eeda 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -11,7 +11,7 @@ IF(NOT CMAKE_BUILD_TYPE)
 ENDIF(NOT CMAKE_BUILD_TYPE)
 
 # Compiler flags
-SET(EXTRA_FLAGS "-Wall -Wextra")
+SET(EXTRA_FLAGS "-Wall -Wextra -Werror -Wnon-virtual-dtor")
 SET(EXTRA_OPTIMIZATION_FLAGS "-Wl,--gc-sections -flto -fmerge-all-constants")
 
 SET(CMAKE_C_FLAGS_PROFILING    "-O2 ${EXTRA_FLAGS}")
diff --git a/src/common/archive_info.h b/src/common/archive_info.h
index 0e27c3f..fb41fed 100644
--- a/src/common/archive_info.h
+++ b/src/common/archive_info.h
@@ -20,6 +20,7 @@ class ArchiveInfo {
   using Dependency = std::tuple<std::string, std::string, std::string>;
 
   explicit ArchiveInfo(std::string path) : path_(std::move(path)) { }
+  virtual ~ArchiveInfo() = default;
   virtual bool LoadArchiveInfo() = 0;
   bool GetPkgDetailInfo(package_manager_pkg_detail_info_t* info);
 
diff --git a/src/common/installer_factory.h b/src/common/installer_factory.h
index 8e7cc4e..27ebbc2 100644
--- a/src/common/installer_factory.h
+++ b/src/common/installer_factory.h
@@ -15,6 +15,7 @@ class AppInstaller;
 
 class InstallerFactory {
  public:
+  virtual ~InstallerFactory() = default;
   virtual std::unique_ptr<AppInstaller> CreateInstaller(PkgMgrPtr pkgmgr,
       int idx) = 0;
 };
diff --git a/src/common/pkgmgr_interface.h b/src/common/pkgmgr_interface.h
index 8d0cfc3..ded0faf 100644
--- a/src/common/pkgmgr_interface.h
+++ b/src/common/pkgmgr_interface.h
@@ -42,6 +42,8 @@ typedef std::shared_ptr<PkgMgrInterface> PkgMgrPtr;
  */
 class PkgmgrInstallerInterface {
  public:
+  virtual ~PkgmgrInstallerInterface() = default;
+
   virtual bool CreatePkgMgrInstaller(pkgmgr_installer** installer,
                              InstallationMode* mode) = 0;
   virtual bool ShouldCreateSignal() const = 0;
diff --git a/test/smoke_tests/common/smoke_utils.h b/test/smoke_tests/common/smoke_utils.h
index 3121b41..628e013 100644
--- a/test/smoke_tests/common/smoke_utils.h
+++ b/test/smoke_tests/common/smoke_utils.h
@@ -227,6 +227,7 @@ bool TouchFile(const boost::filesystem::path& path);
 class SmokeInstallerFactory {
  public:
   using AppInstallerPtr = std::unique_ptr<common_installer::AppInstaller>;
+  virtual ~SmokeInstallerFactory() = default;
   virtual AppInstallerPtr CreateInstaller(
       int idx, common_installer::PkgMgrPtr pkgmgr) const = 0;
   virtual AppInstallerPtr CreateFailExpectedInstaller(
@@ -244,7 +245,7 @@ class BackendInterface {
       std::string uid,
       RequestResult mode = RequestResult::NORMAL)
       : factory_(std::move(factory)), uid_str_(uid), mode_(mode) {}
-  virtual ~BackendInterface() {}
+  virtual ~BackendInterface() = default;
 
   void TestRollbackAfterEachStep(int argc, const char* argv[],
                                  std::function<bool()> validator) const;
@@ -312,6 +313,7 @@ class SmokeTestHelperRunner {
     UnKnown
   };
 
+  virtual ~SmokeTestHelperRunner() = default;
   Result InstallWithSubprocess(const bf::path& path, uid_t uid) const;
   Result MountInstallWithSubprocess(const bf::path& path, uid_t uid) const;
   Result RecoveryWithSubprocess(const bf::path& path, uid_t uid) const;