From: Nishant Chaprana Date: Wed, 29 Jan 2020 06:42:45 +0000 (+0530) Subject: Remove logically dead code when registering D-Bus signals X-Git-Tag: submit/tizen/20200203.052833^2 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=refs%2Fchanges%2F19%2F223419%2F1;p=platform%2Fcore%2Fapi%2Fwifi-manager.git Remove logically dead code when registering D-Bus signals As per Gdbus documentation for g_dbus_connection_signal_subscribe() API. The returned subscription identifier is an opaque value which is guaranteed to never be zero. This function can never fail. Reference: https://developer.gnome.org/gio/stable/GDBusConnection.html#g-dbus-connection-signal-subscribe Change-Id: Idfb4fa84ecf503d1e67430972984c9101f9d9f60 Signed-off-by: Nishant Chaprana --- diff --git a/packaging/capi-network-wifi-manager.spec b/packaging/capi-network-wifi-manager.spec index 7c65fb5..2a63815 100755 --- a/packaging/capi-network-wifi-manager.spec +++ b/packaging/capi-network-wifi-manager.spec @@ -1,6 +1,6 @@ Name: capi-network-wifi-manager Summary: Network Wi-Fi library in TIZEN C API -Version: 1.0.47 +Version: 1.0.48 Release: 1 Group: System/Network License: Apache-2.0 diff --git a/src/network_signal.c b/src/network_signal.c index c1cc3df..5c2670e 100755 --- a/src/network_signal.c +++ b/src/network_signal.c @@ -1863,24 +1863,6 @@ int _net_register_signal(void) NULL, NULL); - if (gdbus_conn_subscribe_id_connman_state == 0 || - gdbus_conn_subscribe_id_connman_error == 0 || - gdbus_conn_subscribe_id_netconfig == 0 || - gdbus_conn_subscribe_id_connman_scandone == 0 || - gdbus_conn_subscribe_id_connman_scanstarted == 0 || - gdbus_conn_subscribe_id_netconfig_wifi == 0) { - WIFI_LOG(WIFI_ERROR, "Failed register signals " //LCOV_EXCL_LINE - "connman_state(%d), connman_error(%d), netconfig(%d), " - "connman_scandone(%d), connman_scanstarted(%d), netconfig_wifi(%d)", - gdbus_conn_subscribe_id_connman_state, - gdbus_conn_subscribe_id_connman_error, - gdbus_conn_subscribe_id_netconfig, - gdbus_conn_subscribe_id_connman_scandone, - gdbus_conn_subscribe_id_connman_scanstarted, - gdbus_conn_subscribe_id_netconfig_wifi); - Error = NET_ERR_NOT_SUPPORTED; //LCOV_EXCL_LINE - } - __NETWORK_FUNC_EXIT__; return Error; }