From: Michal Michalski <m.michalski2@partner.samsung.com>
Date: Fri, 27 Sep 2019 10:48:45 +0000 (+0200)
Subject: [mediacontroller] Check for errors added.
X-Git-Tag: submit/tizen/20190930.141103~2^2
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=refs%2Fchanges%2F13%2F214913%2F4;p=platform%2Fcore%2Fapi%2Fwebapi-plugins.git

[mediacontroller] Check for errors added.

+ Result of native call to SendCommand was not checked for failure.
This commit adds this validation.

+ Added return after error occured in AddPlaybackInfoChangeList().

[Verification] All tests pass.

Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Change-Id: I5e7e74faa1c8902f35e45278c7c05778094867c4
---

diff --git a/src/mediacontroller/mediacontroller_api.js b/src/mediacontroller/mediacontroller_api.js
index 71bfaf61..050802ca 100755
--- a/src/mediacontroller/mediacontroller_api.js
+++ b/src/mediacontroller/mediacontroller_api.js
@@ -3287,6 +3287,9 @@ MediaControllerServerInfo.prototype.sendCommand = function(
 
     var replyListenerId = ReplyCommandListener.addListener(callback);
     var result = native_.callSync('MediaControllerServerInfo_sendCommand', nativeData);
+    if (native_.isFailure(result)) {
+      throw native_.getErrorObject(result);
+    }
 
     ReplyCommandListener.requestIdToListenerId[replyListenerId] = result.requestId;
 };
diff --git a/src/mediacontroller/mediacontroller_instance.cc b/src/mediacontroller/mediacontroller_instance.cc
index 4add4984..268aa288 100644
--- a/src/mediacontroller/mediacontroller_instance.cc
+++ b/src/mediacontroller/mediacontroller_instance.cc
@@ -1415,6 +1415,7 @@ void MediaControllerInstance::MediaControllerServerInfoAddPlaybackInfoChangeList
   auto result = client_->SetPlaybackInfoListener(callback);
   if (!result) {
     LogAndReportError(result, &out);
+    return;
   }
 
   ReportSuccess(out);