From: hyeonseok lee Date: Thu, 19 Jan 2023 09:13:05 +0000 (+0900) Subject: [UTC][nntrainer][Non-ACR] handle heap use after free X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=refs%2Fchanges%2F09%2F287909%2F1;p=test%2Ftct%2Fnative%2Fapi.git [UTC][nntrainer][Non-ACR] handle heap use after free - Even though dataset was not created ml_train_dataset_destroy was added in some cases and it causes heap use after free bug. - Adjust layer_type size to test every layers. Change-Id: I4ee621a888b7f0ae4d264474b9a8d62415003acd Signed-off-by: hyeonseok lee --- diff --git a/src/utc/nntrainer/utc-nntrainer-dataset.c b/src/utc/nntrainer/utc-nntrainer-dataset.c index 9678d31c9..68ab915b6 100644 --- a/src/utc/nntrainer/utc-nntrainer-dataset.c +++ b/src/utc/nntrainer/utc-nntrainer-dataset.c @@ -272,8 +272,6 @@ int utc_nntrainer_dataset_create_n(void) assert_eq(status, ML_ERROR_INVALID_PARAMETER); } - ml_train_dataset_destroy(dataset); - return 0; } @@ -323,8 +321,6 @@ int utc_nntrainer_dataset_add_generator_train_dataset_n1(void) assert_eq(status, ML_ERROR_INVALID_PARAMETER); } - ml_train_dataset_destroy(dataset); - return 0; } @@ -371,8 +367,6 @@ int utc_nntrainer_dataset_add_generator_valid_dataset_n1(void) assert_eq(status, ML_ERROR_INVALID_PARAMETER); } - ml_train_dataset_destroy(dataset); - return 0; } @@ -419,8 +413,6 @@ int utc_nntrainer_dataset_add_generator_test_dataset_n1(void) assert_eq(status, ML_ERROR_INVALID_PARAMETER); } - ml_train_dataset_destroy(dataset); - return 0; } @@ -495,8 +487,6 @@ int utc_nntrainer_dataset_add_file_train_dataset_n1(void) assert_eq(status, ML_ERROR_INVALID_PARAMETER); } - ml_train_dataset_destroy(dataset); - return 0; } @@ -541,8 +531,6 @@ int utc_nntrainer_dataset_add_file_valid_dataset_n1(void) assert_eq(status, ML_ERROR_INVALID_PARAMETER); } - ml_train_dataset_destroy(dataset); - return 0; } @@ -587,8 +575,6 @@ int utc_nntrainer_dataset_add_file_test_dataset_n1(void) assert_eq(status, ML_ERROR_INVALID_PARAMETER); } - ml_train_dataset_destroy(dataset); - return 0; } diff --git a/src/utc/nntrainer/utc-nntrainer-layer.c b/src/utc/nntrainer/utc-nntrainer-layer.c index 0c56477ee..f27dfcc37 100644 --- a/src/utc/nntrainer/utc-nntrainer-layer.c +++ b/src/utc/nntrainer/utc-nntrainer-layer.c @@ -115,7 +115,7 @@ int utc_nntrainer_layer_create_p2(void) ML_TRAIN_LAYER_TYPE_LOSS_CROSS_ENTROPY_SIGMOID, ML_TRAIN_LAYER_TYPE_LOSS_CROSS_ENTROPY_SOFTMAX, }; - const unsigned int layer_types_size = 23; + const unsigned int layer_types_size = 33; unsigned int i = 0; for (i = 0; i < layer_types_size; ++i)