From: Michal Bloch <m.bloch@samsung.com>
Date: Fri, 18 Mar 2022 16:22:41 +0000 (+0100)
Subject: readers: initialize fd entities properly
X-Git-Tag: submit/tizen/20220405.121801~5
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=refs%2Fchanges%2F08%2F273008%2F2;p=platform%2Fcore%2Fsystem%2Fdlog.git

readers: initialize fd entities properly

Set the FD inside to -1 (as opposed to 0).
If something fails during init, that FD gets closed.

Change-Id: Ic50cadabc7ca4ec514e40878d49df027e450e61c
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
---

diff --git a/src/logger/reader_logger.c b/src/logger/reader_logger.c
index 0085d4c..8965589 100644
--- a/src/logger/reader_logger.c
+++ b/src/logger/reader_logger.c
@@ -96,6 +96,9 @@ static struct reader_logger *reader_logger_alloc(void)
 	if (!ret)
 		return NULL;
 
+	init_fd_entity(&ret->common.fd_entity_sink  , NULL, NULL);
+	init_fd_entity(&ret->common.fd_entity_source, NULL, NULL);
+
 	ret->buf_id = LOG_ID_INVALID;
 	ret->common.service_reader = service_reader_logger;
 
diff --git a/src/logger/reader_pipe.c b/src/logger/reader_pipe.c
index 021d934..052ea87 100644
--- a/src/logger/reader_pipe.c
+++ b/src/logger/reader_pipe.c
@@ -63,6 +63,9 @@ static struct reader_pipe *reader_pipe_alloc(struct log_filter *filter, struct l
 	if (!ret)
 		return NULL;
 
+	init_fd_entity(&ret->common.fd_entity_sink  , NULL, NULL);
+	init_fd_entity(&ret->common.fd_entity_source, NULL, NULL);
+
 	ret->common.service_reader = print_out_logs;
 	ret->filter = log_filter_move(filter);
 	ret->monitor = monitor;