From: Sangyoon Jang <jeremy.jang@samsung.com>
Date: Thu, 15 May 2025 07:47:20 +0000 (+0900)
Subject: Fix variable shadowing
X-Git-Tag: accepted/tizen/unified/20250516.055923~1
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=refs%2Fchanges%2F02%2F324302%2F2;p=platform%2Fcore%2Fappfw%2Ftizen-action.git

Fix variable shadowing

-Werror=shadow added.

Requies:
 - https://review.tizen.org/gerrit/c/platform/core/base/bundle/+/324305

Change-Id: I1642841b1b3499e1b23c521661286f89cfc60fb7
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
---

diff --git a/CMakeLists.txt b/CMakeLists.txt
index 73c1a20..fca33a8 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -8,7 +8,7 @@ SET(LIBDIR ${LIB_INSTALL_DIR})
 SET(INCLUDEDIR "\${prefix}/include")
 
 ## Compiler flags
-SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -std=c++17 -Wall -Werror -ffunction-sections -fdata-sections -fmerge-all-constants -fPIE -fPIC")
+SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -std=c++17 -Wall -Werror -Werror=shadow -ffunction-sections -fdata-sections -fmerge-all-constants -fPIE -fPIC")
 
 ## Linker flags
 SET(CMAKE_EXE_LINKER_FLAGS "-Wl,--as-needed,--gc-sections -pie")
diff --git a/src/api/connector.cc b/src/api/connector.cc
index ba02dc4..5498921 100644
--- a/src/api/connector.cc
+++ b/src/api/connector.cc
@@ -143,8 +143,8 @@ void Connector::UnregisterUserCallback(int execution_id) {
 void Connector::InvokeUserCallback(int execution_id,
     const std::string& result) {
   auto it = std::find_if(user_callbacks_.begin(), user_callbacks_.end(),
-      [&execution_id](auto&& it) {
-        return std::get<0>(it) == execution_id;
+      [&execution_id](auto&& callbacks_it) {
+        return std::get<0>(callbacks_it) == execution_id;
       });
   if (it == user_callbacks_.end()) {
     LOG(ERROR) << "No callback found for execution id: " << execution_id;
diff --git a/src/plugin-daemon/plugin_sample_so.cc b/src/plugin-daemon/plugin_sample_so.cc
index b26c082..e792944 100644
--- a/src/plugin-daemon/plugin_sample_so.cc
+++ b/src/plugin-daemon/plugin_sample_so.cc
@@ -67,9 +67,9 @@ API const char* PLUGIN_EXECUTE(const char* action_model_json) {
     LOG(INFO) << "param1: " << param1 << ", param2: " << param2;
     result.set("result", "success");
   } catch (const std::runtime_error& e) {
-    common::SafeJson result("{}");
-    result.set("error", e.what());
-    return strdup(result.stringify().c_str());
+    common::SafeJson error_result("{}");
+    error_result.set("error", e.what());
+    return strdup(error_result.stringify().c_str());
   }
 
   return strdup(result.stringify().c_str());