From: Jihoon Kim <jihoon48.kim@samsung.com>
Date: Thu, 16 Mar 2017 03:48:10 +0000 (+0900)
Subject: Fix deference after NULL issue
X-Git-Tag: accepted/tizen/3.0/common/20170316.121945~1
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=refs%2Fchanges%2F02%2F119202%2F1;p=platform%2Fcore%2Fuifw%2Fise-default.git

Fix deference after NULL issue

After having been compared to NULL value at ise.cpp:671, pointer 'g_ui' is dereferenced at ise.cpp:677.

Change-Id: Id43fed950a453c1cc0ddeeae01ed7c5b81fcd885
Signed-off-by: Jihoon Kim <jihoon48.kim@samsung.com>
---

diff --git a/src/ise.cpp b/src/ise.cpp
index 5d24d46..238dde4 100644
--- a/src/ise.cpp
+++ b/src/ise.cpp
@@ -668,13 +668,14 @@ void ise_show_help_popup(sclulong keyEvent)
     sclint scr_h = 0;
     SclRectangle rectangle = {0};
 
-    if (g_ui)
+    if (g_ui) {
         g_ui->get_screen_resolution(&scr_w, &scr_h);
 
-    if (keyEvent == MVK_space) {
-        g_ui->get_button_geometry("SPACE_KEY", &rectangle);
-    } else {
-        g_ui->get_button_geometry("CM_KEY", &rectangle);
+        if (keyEvent == MVK_space) {
+            g_ui->get_button_geometry("SPACE_KEY", &rectangle);
+        } else {
+            g_ui->get_button_geometry("CM_KEY", &rectangle);
+        }
     }
 
     _guide_popup_window = open_message_popup(NATIVE_WINDOW_CAST(ime_get_main_window()));