From: Jeongmo Yang <jm80.yang@samsung.com>
Date: Mon, 7 Oct 2024 07:23:35 +0000 (+0900)
Subject: Fix ASAN issue : heap-use-after-free
X-Git-Tag: accepted/tizen/unified/20241007.161057^0
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=refs%2Fchanges%2F01%2F318701%2F2;p=platform%2Fcore%2Fapi%2Fmediacodec.git

Fix ASAN issue : heap-use-after-free

[Version] 1.1.3
[Issue Type] ASAN

Change-Id: I54ed52ae0b94c3fdd595266ceda5185bb5656958
Signed-off-by: Jeongmo Yang <jm80.yang@samsung.com>
---

diff --git a/packaging/capi-media-codec.spec b/packaging/capi-media-codec.spec
index e13c349..db1a254 100644
--- a/packaging/capi-media-codec.spec
+++ b/packaging/capi-media-codec.spec
@@ -4,7 +4,7 @@
 
 Name:       capi-media-codec
 Summary:    A Media Codec library in Tizen Native API
-Version:    1.1.2
+Version:    1.1.3
 Release:    0
 Group:      Multimedia/API
 License:    Apache-2.0
diff --git a/src/media_codec.c b/src/media_codec.c
index 732a76d..599cc49 100644
--- a/src/media_codec.c
+++ b/src/media_codec.c
@@ -146,10 +146,6 @@ int mediacodec_create(mediacodec_h *mediacodec)
 		handle = NULL;
 		return MEDIACODEC_ERROR_INVALID_OPERATION;
 //LCOV_EXCL_STOP
-	} else {
-		*mediacodec = (mediacodec_h)handle;
-		handle->state = MEDIACODEC_STATE_IDLE;
-		LOGD("new handle : %p", *mediacodec);
 	}
 
 	/* set callback */
@@ -174,6 +170,11 @@ int mediacodec_create(mediacodec_h *mediacodec)
 	}
 #endif
 
+	handle->state = MEDIACODEC_STATE_IDLE;
+	*mediacodec = (mediacodec_h)handle;
+
+	LOGD("new handle : %p", *mediacodec);
+
 	return MEDIACODEC_ERROR_NONE;
 
 }