From: SukhyungKang <shine.kang@samsung.com>
Date: Wed, 6 Mar 2024 04:31:42 +0000 (+0900)
Subject: change to use std::move to avoid copy
X-Git-Tag: accepted/tizen/unified/20240307.075333~1
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=refs%2Fchanges%2F01%2F307201%2F1;p=platform%2Fcore%2Fappfw%2Fwidget-service.git

change to use std::move to avoid copy

Change-Id: I3d712dfce6b7dcfa98a34a87eb109633549db206
Signed-off-by: SukhyungKang <shine.kang@samsung.com>
---

diff --git a/parser/lib/widget_plugin_parser_db.cc b/parser/lib/widget_plugin_parser_db.cc
index 859fe09..bf8d816 100644
--- a/parser/lib/widget_plugin_parser_db.cc
+++ b/parser/lib/widget_plugin_parser_db.cc
@@ -194,7 +194,7 @@ int WidgetPluginParser::Remove(const std::string& pkgid) {
 int WidgetPluginParser::Impl::InsertWidgetClass(const tizen_base::Database& db,
     const std::string& pkgid) {
   for (const auto& i : info_list_) {
-    auto q = tizen_base::Database::Sql(
+    auto q = std::move(tizen_base::Database::Sql(
         "INSERT OR REPLACE INTO widget_class (classid, update_period, "
         "setup_appid, appid, pkgid, nodisplay, max_instance, prime) "
         "VALUES (?, ?, ?, ?, ?, ?, ?, ?)")
@@ -206,7 +206,7 @@ int WidgetPluginParser::Impl::InsertWidgetClass(const tizen_base::Database& db,
         .Bind(pkgid)
         .Bind(i.GetNoDisplay())
         .Bind(i.GetMaxInstance())
-        .Bind(i.GetPrime());
+        .Bind(i.GetPrime()));
     auto r = db.Exec(q);
     if (!static_cast<bool>(r))
       return -1;
@@ -233,10 +233,10 @@ int WidgetPluginParser::Impl::InsertWidgetClass(const tizen_base::Database& db,
 
 int WidgetPluginParser::Impl::RemoveWidgetClass(const tizen_base::Database& db,
     const std::string& pkgid) {
-  auto q = tizen_base::Database::Sql(
+  auto q = std::move(tizen_base::Database::Sql(
       "DELETE FROM widget_class WHERE pkgid=?")
       .SetEmptyStringAsNull(true)
-      .Bind(pkgid);
+      .Bind(pkgid));
 
   auto r = db.Exec(q);
   if (!static_cast<bool>(r))
@@ -249,7 +249,7 @@ int WidgetPluginParser::Impl::InsertSupportSize(const tizen_base::Database& db,
     const std::string& pkgid, const std::string& classid,
     const std::list<WidgetInfo::SupportSize>& sizes) {
   for (const auto& i : sizes) {
-    auto q = tizen_base::Database::Sql(
+    auto q = std::move(tizen_base::Database::Sql(
         "INSERT OR REPLACE INTO support_size "
         "(classid, preview, frame, width, height) "
         "VALUES (?, ?, ?, ?, ?)")
@@ -258,7 +258,7 @@ int WidgetPluginParser::Impl::InsertSupportSize(const tizen_base::Database& db,
         .Bind(ConvertPath(i.GetPreview(), pkgid))
         .Bind(i.IsFrame() ? 1 : 0)
         .Bind(i.GetWidth())
-        .Bind(i.GetHeight());
+        .Bind(i.GetHeight()));
     auto r = db.Exec(q);
     if (!static_cast<bool>(r))
       return -1;
@@ -271,13 +271,13 @@ int WidgetPluginParser::Impl::InsertLabel(const tizen_base::Database& db,
     const std::string& classid,
     const std::list<WidgetInfo::Label>& labels) {
   for (const auto& i : labels) {
-    auto q = tizen_base::Database::Sql(
+    auto q = std::move(tizen_base::Database::Sql(
         "INSERT OR REPLACE INTO label (classid, locale, label) "
         "VALUES (?, ?, ?)")
         .SetEmptyStringAsNull(true)
         .Bind(classid)
         .Bind(i.GetLang())
-        .Bind(i.GetLabel());
+        .Bind(i.GetLabel()));
     auto r = db.Exec(q);
     if (!static_cast<bool>(r))
       return -1;
@@ -290,13 +290,13 @@ int WidgetPluginParser::Impl::InsertIcon(const tizen_base::Database& db,
     const std::string& pkgid, const std::string& classid,
     const std::list<WidgetInfo::Icon>& icons) {
   for (const auto& i : icons) {
-    auto q = tizen_base::Database::Sql(
+    auto q = std::move(tizen_base::Database::Sql(
         "INSERT OR REPLACE INTO icon (classid, locale, icon) "
         "VALUES (?, ?, ?)")
         .SetEmptyStringAsNull(true)
         .Bind(classid)
         .Bind(i.GetLang())
-        .Bind(ConvertPath(i.GetIcon(), pkgid));
+        .Bind(ConvertPath(i.GetIcon(), pkgid)));
     auto r = db.Exec(q);
     if (!static_cast<bool>(r))
       return -1;