From: Chenthill Palanisamy <pchen@src.gnome.org>
Date: Fri, 8 Sep 2006 08:17:22 +0000 (+0000)
Subject: Fixes a invalid read.
X-Git-Tag: upstream/3.7.4~6024
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=fff860b9997fbffbc0ff530ef478c203cff91c22;p=platform%2Fupstream%2Fevolution-data-server.git

Fixes a invalid read.
---

diff --git a/calendar/ChangeLog b/calendar/ChangeLog
index 57903be..922fd64 100644
--- a/calendar/ChangeLog
+++ b/calendar/ChangeLog
@@ -1,3 +1,10 @@
+2006-09-06  Chenthill Palanisamy  <pchenthill@novell.com>
+
+	Fixes a invalid read.
+	* backends/http/e-cal-backend-http.c: (retrieval_done):
+	clone the icalcomp before setting it in the new ECalComponent.
+	See bug #352596
+
 2006-08-24  Chenthill Palanisamy  <pchenthill@novell.com>
 
 	Fixes the gslice crash
diff --git a/calendar/backends/http/e-cal-backend-http.c b/calendar/backends/http/e-cal-backend-http.c
index 92c0e0b..0e623c9 100644
--- a/calendar/backends/http/e-cal-backend-http.c
+++ b/calendar/backends/http/e-cal-backend-http.c
@@ -330,7 +330,7 @@ retrieval_done (SoupMessage *msg, ECalBackendHttp *cbhttp)
 
 		if (subcomp_kind == kind) {
 			comp = e_cal_component_new ();
-			if (e_cal_component_set_icalcomponent (comp, subcomp)) {
+			if (e_cal_component_set_icalcomponent (comp, icalcomponent_new_clone (subcomp))) {
 				const char *uid, *orig_key, *orig_value;
 
 				e_cal_backend_cache_put_component (priv->cache, comp);
@@ -352,7 +352,7 @@ retrieval_done (SoupMessage *msg, ECalBackendHttp *cbhttp)
 			icaltimezone *zone;
 
 			zone = icaltimezone_new ();
-			icaltimezone_set_component (zone, subcomp);
+			icaltimezone_set_component (zone, icalcomponent_new_clone (subcomp));
 			e_cal_backend_cache_put_timezone (priv->cache, (const icaltimezone *) zone);
 
 			icaltimezone_free (zone, 1);