From: Sebastian Ott Date: Thu, 25 Apr 2013 11:03:18 +0000 (+0200) Subject: s390/scm_blk: fix memleak in init function X-Git-Tag: accepted/tizen/common/20141203.182822~2446^2~1 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=fff60fabc71c41bd1bd4beb4fdd735bb8e01096c;p=platform%2Fkernel%2Flinux-arm64.git s390/scm_blk: fix memleak in init function If the allocation of a single request fails the already allocated requests will not be freed. Reviewed-by: Peter Oberparleiter Signed-off-by: Sebastian Ott Signed-off-by: Martin Schwidefsky --- diff --git a/drivers/s390/block/scm_blk.c b/drivers/s390/block/scm_blk.c index e9b9c83..b303cab 100644 --- a/drivers/s390/block/scm_blk.c +++ b/drivers/s390/block/scm_blk.c @@ -465,7 +465,7 @@ static int __init scm_blk_init(void) scm_major = ret; ret = scm_alloc_rqs(nr_requests); if (ret) - goto out_unreg; + goto out_free; scm_debug = debug_register("scm_log", 16, 1, 16); if (!scm_debug) { @@ -486,7 +486,6 @@ out_dbf: debug_unregister(scm_debug); out_free: scm_free_rqs(); -out_unreg: unregister_blkdev(scm_major, "scm"); out: return ret;