From: Heinrich Schuchardt <xypron.glpk@gmx.de>
Date: Sun, 8 May 2016 21:20:59 +0000 (+0200)
Subject: usb: gadget: avoid exposing kernel stack
X-Git-Tag: v4.14-rc1~3008^2~46^2~5
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=ffeee83aa0461992e8a99a59db2df31933e60362;p=platform%2Fkernel%2Flinux-rpi.git

usb: gadget: avoid exposing kernel stack

Function in_rq_cur copies random bytes from the stack.
Zero the memory instead.

Fixes: 132fcb460839 ("usb: gadget: Add Audio Class 2.0 Driver")
Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
---

diff --git a/drivers/usb/gadget/function/f_uac2.c b/drivers/usb/gadget/function/f_uac2.c
index 1c81dd3..cd214ec 100644
--- a/drivers/usb/gadget/function/f_uac2.c
+++ b/drivers/usb/gadget/function/f_uac2.c
@@ -1280,6 +1280,7 @@ in_rq_cur(struct usb_function *fn, const struct usb_ctrlrequest *cr)
 
 	if (control_selector == UAC2_CS_CONTROL_SAM_FREQ) {
 		struct cntrl_cur_lay3 c;
+		memset(&c, 0, sizeof(struct cntrl_cur_lay3));
 
 		if (entity_id == USB_IN_CLK_ID)
 			c.dCUR = p_srate;