From: Colin Ian King Date: Tue, 10 Apr 2018 12:33:12 +0000 (+0100) Subject: drm/i915/gvt: fix memory leak of a cmd_entry struct on error exit path X-Git-Tag: v4.19~774^2~1^2^2~4 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=ffdf16edfbbe77f5f5c3c87fe8d7387ecd16241b;p=platform%2Fkernel%2Flinux-rpi.git drm/i915/gvt: fix memory leak of a cmd_entry struct on error exit path The error exit path when a duplicate is found does not kfree and cmd_entry struct and hence there is a small memory leak. Fix this by kfree'ing it. Detected by CoverityScan, CID#1370198 ("Resource Leak") Fixes: be1da7070aea ("drm/i915/gvt: vGPU command scanner") Signed-off-by: Colin Ian King Reviewed-by: Chris Wilson Signed-off-by: Zhenyu Wang --- diff --git a/drivers/gpu/drm/i915/gvt/cmd_parser.c b/drivers/gpu/drm/i915/gvt/cmd_parser.c index db6b94d..6bd56ec 100644 --- a/drivers/gpu/drm/i915/gvt/cmd_parser.c +++ b/drivers/gpu/drm/i915/gvt/cmd_parser.c @@ -2863,6 +2863,7 @@ static int init_cmd_table(struct intel_gvt *gvt) if (info) { gvt_err("%s %s duplicated\n", e->info->name, info->name); + kfree(e); return -EEXIST; }