From: Dan Carpenter Date: Fri, 10 Aug 2012 08:25:03 +0000 (-0300) Subject: [media] qt1010: signedness bug in qt1010_init_meas1() X-Git-Tag: v3.7-rc2~24^2~585 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=ffd491fd6f4129c201926edbbd63e2088d82d2fa;p=profile%2Fivi%2Fkernel-adaptation-intel-automotive.git [media] qt1010: signedness bug in qt1010_init_meas1() qt1010_init_meas2() returns zero on success and negative error codes on failure so the return type should be int instead of u8. Signed-off-by: Dan Carpenter Acked-by: Antti Palosaari Signed-off-by: Mauro Carvalho Chehab --- diff --git a/drivers/media/common/tuners/qt1010.c b/drivers/media/common/tuners/qt1010.c index 2d79b1f..bdc39e1 100644 --- a/drivers/media/common/tuners/qt1010.c +++ b/drivers/media/common/tuners/qt1010.c @@ -288,7 +288,7 @@ static int qt1010_init_meas1(struct qt1010_priv *priv, return qt1010_writereg(priv, 0x1e, 0x00); } -static u8 qt1010_init_meas2(struct qt1010_priv *priv, +static int qt1010_init_meas2(struct qt1010_priv *priv, u8 reg_init_val, u8 *retval) { u8 i, val;